Skip to content

[7.x] Ensure comments on parameters in arrow functions are captured in the docs and ci metrics. (#100823)#101087

Merged
stacey-gammon merged 1 commit intoelastic:7.xfrom
stacey-gammon:backport/7.x/pr-100823
Jun 1, 2021
Merged

[7.x] Ensure comments on parameters in arrow functions are captured in the docs and ci metrics. (#100823)#101087
stacey-gammon merged 1 commit intoelastic:7.xfrom
stacey-gammon:backport/7.x/pr-100823

Conversation

@stacey-gammon
Copy link

Backports the following commits to 7.x:

…docs and ci metrics. (elastic#100823)

* Make sure arrow functions capture parameter comments.

* Update docs
# Conflicts:
#	api_docs/apm.json
#	api_docs/core.json
#	api_docs/data.json
#	api_docs/data_index_patterns.json
#	api_docs/data_search.json
#	api_docs/licensing.json
#	api_docs/reporting.json
#	api_docs/spaces.json
@stacey-gammon stacey-gammon added the backport This PR is a backport of another PR label Jun 1, 2021
@stacey-gammon stacey-gammon enabled auto-merge (squash) June 1, 2021 19:30
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
charts 157 155 -2
core 1073 1061 -12
data 3286 3245 -41
embeddable 381 379 -2
expressions 1456 1444 -12
kibanaReact 218 216 -2
kibanaUtils 385 373 -12
presentationUtil 123 121 -2
total -85
Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 256 146 -110
lens 67 45 -22
licensing 18 15 -3
lists 239 236 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
securitySolution 390 346 -44
stackAlerts 101 95 -6
total -340

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stacey-gammon stacey-gammon merged commit 2cad521 into elastic:7.x Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants