[Alerting] Adding feature flag for enabling/disabling rule import and export#100718
Merged
ymao1 merged 3 commits intoelastic:masterfrom May 28, 2021
Merged
Conversation
ymao1
commented
May 26, 2021
| [role="screenshot"] | ||
| image:images/bulk-mute-disable.png[The Manage rules button lets you mute/unmute, enable/disable, and delete in bulk] | ||
|
|
||
| [float] |
Contributor
Author
There was a problem hiding this comment.
Removed this section from the docs until we can enable it by default.
ymao1
added
Feature:Alerting
release_note:skip
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
Contributor
|
Right now, |
Contributor
Author
It shouldn't control import/export of actions/connectors. Are you unable to export actions/connectors when the flag is false? |
Contributor
|
@ymao1 Ah yes you're right. My mistake! Thanks for clarifying |
Contributor
|
I'd suggest filing a separate issue for this (if necessary), but is there something we can to improve the UX of importing an alert when this config is turned off? Maybe something like "To import this alert, please enable the feature flag"
|
Contributor
chrisronline
left a comment
chrisronline
left a comment
There was a problem hiding this comment.
Left one outstanding question, but otherwise this looks great!
Contributor
Author
I think since we're doing this through the Saved objects management UI, we should defer to their handling of unrecognized object types. What do you think? |
Contributor
|
@ymao1 Sure, sounds good. I just wasn't sure if we had more control there. It'd be nice to give the users as much insight into why the object is unsupported (assuming we know of course) but I'm happy to rely on the existing messaging as it does handle this case. |
chrisronline
approved these changes
May 27, 2021
Contributor
Author
|
@elasticmachine merge upstream |
ymao1
added
the
auto-backport
Contributor
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / general / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/spaces/spaces_selection·ts.Spaces app Spaces Space Selector allows user to navigate to different spacesStandard OutStack TraceMetrics [docs]History
To update your PR or re-run it, just comment with: cc @ymao1 |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
May 28, 2021
… export (elastic#100718) * Adding feature flag for enabling rule import and export * Removing item from docs Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Contributor
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 28, 2021
* master: (77 commits) [RAC][Security Solution] Register Security Detection Rules with Rule Registry (elastic#96015) [Enterprise Search] Log warning for Kibana/EntSearch version mismatches (elastic#100809) updating the saved objects test to include more saved object types (elastic#100828) [ML] Fix categorization job view examples link when datafeed uses multiple indices (elastic#100789) Fixing ES archive mapping failure (elastic#100835) Fix bug with Observability > APM header navigation (elastic#100845) [Security Solution][Endpoint] Add event filters summary card to the fleet endpoint tab (elastic#100668) [Actions] Taking space id into account when creating email footer link (elastic#100734) Ensure comments on parameters in arrow functions are captured in the docs and ci metrics. (elastic#100823) [Security Solution] Improve find rule and find rule status route performance (elastic#99678) [DOCS] Adds video to introduction (elastic#100906) [Fleet] Improve combo box for fleet settings (elastic#100603) [Security Solution][Endpoint] Endpoint generator and data loader support for Host Isolation (elastic#100813) [DOCS] Adds Lens video (elastic#100898) [TSVB] [Table tab] Fix "Math" aggregation (elastic#100765) chore(NA): moving @kbn/io-ts-utils into bazel (elastic#100810) [Alerting] Adding feature flag for enabling/disabling rule import and export (elastic#100718) [TSVB] Fix Upgrading from 7.12.1 to 7.13.0 breaks TSVB (elastic#100864) [Lens] Adds dynamic table cell coloring (elastic#95217) [Security Solution][Endpoint] Do not display searchbar in security-trusted apps if there are no items (elastic#100853) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #100145
Summary
Added
xpack.alerting.enableImportExportto control whether exporting of rules is available. Defaults tofalse.To Verify
Run this PR branch. Create some rules and connectors. Go to Saved Objects Management UI and see that connectors are available for export but rules are not. Now set
xpack.alerting.enableImportExporttotruein yourkibana.dev.yml. Reload the UI and see that rules are now listed for export in the Saved Objects Management UI.Checklist