Adding bottom In/out panel transition icons#9528
Adding bottom In/out panel transition icons#9528weronikaolejniczak merged 4 commits intoelastic:mainfrom
Conversation
Made-with: Cursor
|
Hey, @l-suarez 👋🏻 thanks for contributing, so exciting! We're missing one thing:
|
Made-with: Cursor
|
Thanks @weronikaolejniczak, yes! it's my first PR :) so excited, I hope I did it right, I had help from an amazing engineer. |
|
@l-suarez AFAIK we'd also need to add these SVGs to EUI Borealis library. We need to ensure parity between Figma and code. Icons LGTM but pinging @MichaelMarcialis just in case (sorry, Jose is on PTO 🙏🏻) |
|
Cool, both added to the Figma library |
💚 Build SucceededHistory
|
weronikaolejniczak
left a comment
There was a problem hiding this comment.
Yay! 🎉 First PR done 🥳
I see that Michael is also off, but I checked both SVGs and they look good 👌🏻 thank you for adding them to Figma lib. Let's merge this! 🟢
💚 Build Succeeded
History
|
Co-authored-by: Weronika Olejniczak <32842468+weronikaolejniczak@users.noreply.github.com>
## Dependency updates - `@elastic/eui` - v114.0.0 ⏩ v114.1.0 - `@elastic/eslint-plugin-eui` - v2.11.0 ⏩ v2.11.1 --- ## Package updates ### @elastic/eui [`v114.1.0`](https://github.com/elastic/eui/releases/v114.1.0) - Added an optional `tooltipProps` prop to `EuiMarkdownEditorHelpButton` ([#9546](elastic/eui#9546)) - Added a warning when non-recommended units are used in `width`, `minWidth` or `maxWidth` props on `<EuiTableFooterCell>`, `<EuiTableHeaderCell>`, `<EuiTableHeaderCellCheckbox>` as well as the `columns` configuration on `<EuiBasicTable>` and `<EuiInMemoryTable>` ([#9540](elastic/eui#9540)) - Added `transitionBottomIn` and `transitionBottomOut` icons to `EuiIcon` ([#9528](elastic/eui#9528)) **Bug fixes** - Fixed `EuiFlyoutManager` animation flickering when switching between flyout sessions by removing intermediate transition stages (backgrounding, returning, closing) and limiting opening animations to the initial flyout and first child only ([#9514](elastic/eui#9514)) - Fixed rendering of `EuiTableHeaderMobile` when `responsiveBreakpoint=false` prop is set ([#9531](elastic/eui#9531)) ### @elastic/eslint-plugin-eui v2.11.1 **Bug fixes** - Fixed `no-css-color` ESLint rule crash when analyzing functions that return `undefined` or non-object values ([#9368](elastic/eui#9368)) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
## Dependency updates - `@elastic/eui` - v114.0.0 ⏩ v114.1.0 - `@elastic/eslint-plugin-eui` - v2.11.0 ⏩ v2.11.1 --- ## Package updates ### @elastic/eui [`v114.1.0`](https://github.com/elastic/eui/releases/v114.1.0) - Added an optional `tooltipProps` prop to `EuiMarkdownEditorHelpButton` ([elastic#9546](elastic/eui#9546)) - Added a warning when non-recommended units are used in `width`, `minWidth` or `maxWidth` props on `<EuiTableFooterCell>`, `<EuiTableHeaderCell>`, `<EuiTableHeaderCellCheckbox>` as well as the `columns` configuration on `<EuiBasicTable>` and `<EuiInMemoryTable>` ([elastic#9540](elastic/eui#9540)) - Added `transitionBottomIn` and `transitionBottomOut` icons to `EuiIcon` ([elastic#9528](elastic/eui#9528)) **Bug fixes** - Fixed `EuiFlyoutManager` animation flickering when switching between flyout sessions by removing intermediate transition stages (backgrounding, returning, closing) and limiting opening animations to the initial flyout and first child only ([elastic#9514](elastic/eui#9514)) - Fixed rendering of `EuiTableHeaderMobile` when `responsiveBreakpoint=false` prop is set ([elastic#9531](elastic/eui#9531)) ### @elastic/eslint-plugin-eui v2.11.1 **Bug fixes** - Fixed `no-css-color` ESLint rule crash when analyzing functions that return `undefined` or non-object values ([elastic#9368](elastic/eui#9368)) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Made-with: Cursor
Summary
transitionBottomInandtransitionBottomOut, complementing the existingtransitionLeftIn,transitionLeftOut,transitionTopIn, andtransitionTopOuticon set.packages/eui/src/components/icon/svgs/icon_map.tsicon_types.ts) for display on the icons pageQA
yarn compile-iconsto generate TSX assets from SVGsyarn run test-unit icon -u— all 769 tests passed, 2 snapshots writtenScreenshot
New icons
Icon library in my local
Impact Assessment
Impact level: 🟢 Low
Release Readiness
QA instructions for reviewer
1. Visual verification
yarn workspace @elastic/eui-website build:workspaces && yarn workspace @elastic/eui-website starttransitionBottom— bothtransitionBottomInandtransitionBottomOutshould appear in the icons grid2. Icon consistency
transitionBottomIn/transitionBottomOutagainsttransitionTopIn/transitionTopOutandtransitionLeftIn/transitionLeftOut— they should follow the same visual language (arrow direction + hatched panel pattern)transitionBottomIn: arrow pointing up (into the panel), hatched area at the bottomtransitionBottomOut: arrow pointing down (out of the panel), hatched area at the bottom3. Code review checklist
packages/eui/src/components/icon/svgs/— two new SVG files (transition_bottom_in.svg,transition_bottom_out.svg) withviewBox="0 0 16 16"packages/eui/src/components/icon/assets/— two generated TSX files (transition_bottom_in.tsx,transition_bottom_out.tsx) with// THIS IS A GENERATED FILEheaderpackages/eui/src/components/icon/icon_map.ts—transitionBottomInandtransitionBottomOutentries placed alphabetically beforetransitionLeftInpackages/website/docs/components/display/icons/icon_types.ts— both icon names added alphabetically beforetransitionLeftInpackages/eui/src/components/icon/__snapshots__/icon.test.tsx.snap— two new snapshots added4. Tests
yarn run test-unit icon -ufrompackages/eui— all tests should pass with no unexpected snapshot changes- [x] Filled out all sections above
, high contrast, mobile, Chrome/Safari/Edge/Firefox, keyboard-only, screen reader— Icons are purely visual SVGs with no interactive behavior; tested light and dark mode renderingQA: Tested in CodeSandbox and Kibana— New icons are additive and not yet consumed in Kibana, Cypress, and VRT— Jest snapshots updated; no interactive behavior requiring Cypress; VRT will be captured automaticallyBreaking changes: Added— Not applicable; purely additive changebreaking changelabelReviewer checklist