Skip to content

Add 3 new icons from EUI: add_to_dashboard, transition_bottom_in/out#3142

Merged
florent-leborgne merged 2 commits into
mainfrom
flb-icon-refresh-2025
Apr 20, 2026
Merged

Add 3 new icons from EUI: add_to_dashboard, transition_bottom_in/out#3142
florent-leborgne merged 2 commits into
mainfrom
flb-icon-refresh-2025

Conversation

@florent-leborgne
Copy link
Copy Markdown
Member

Summary

Syncs docs-builder with recent icon additions by Laura Suarez in EUI:

  • add_to_dashboardEUI #9590 (Apr 2026)
  • transition_bottom_inEUI #9528 (Mar 2026)
  • transition_bottom_outEUI #9528 (Mar 2026)

Also adds the three entries to docs/syntax/icons.md.

Related to the previous icon refresh: #2043

Made with Cursor

Syncs docs-builder with recent EUI additions by Laura Suarez:
- add_to_dashboard (EUI #9590, Apr 2026)
- transition_bottom_in / transition_bottom_out (EUI #9528, Mar 2026)

Also updates docs/syntax/icons.md with the new entries.

Made-with: Cursor
@florent-leborgne florent-leborgne requested review from a team as code owners April 17, 2026 20:02
@coderabbitai coderabbitai Bot added documentation Improvements or additions to documentation chore labels Apr 17, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 17, 2026

📝 Walkthrough

Walkthrough

Two configuration and documentation files were updated. The .gitignore file was modified to exclude the .worktrees/ directory from version control. The docs/syntax/icons.md documentation was extended with three new icon entries: add_to_dashboard, transition_bottom_in, and transition_bottom_out. Both changes are additive with no modifications to existing logic or structure.

Suggested labels

documentation, chore

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and accurately summarizes the main change: adding three new icons (add_to_dashboard, transition_bottom_in/out) from EUI.
Description check ✅ Passed The description is directly related to the changeset, providing context on the three icons being added, their EUI PR origins, commit dates, and related documentation updates.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch flb-icon-refresh-2025

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/syntax/icons.md`:
- Line 12: The docs list icons add_to_dashboard, transition_bottom_in, and
transition_bottom_out but they are not registered in the EUI icon cache; open
the eui-icons-cache.ts file and add the corresponding imports for those three
SVG/icon modules and add mapping entries to the ICONS (or equivalent export)
using the same naming/registration pattern as the existing icons so the tokens
`{icon}`add_to_dashboard``, `{icon}`transition_bottom_in``, and
`{icon}`transition_bottom_out`` resolve at runtime; ensure the import names and
keys exactly match the doc identifiers and follow the existing code style for
registration.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 68374024-dd46-4886-b25e-9c4bf12d71bf

📥 Commits

Reviewing files that changed from the base of the PR and between 5795d21 and f96e715.

⛔ Files ignored due to path filters (3)
  • src/Elastic.Documentation.Svg/svgs/add_to_dashboard.svg is excluded by !**/*.svg
  • src/Elastic.Documentation.Svg/svgs/transition_bottom_in.svg is excluded by !**/*.svg
  • src/Elastic.Documentation.Svg/svgs/transition_bottom_out.svg is excluded by !**/*.svg
📒 Files selected for processing (2)
  • .gitignore
  • docs/syntax/icons.md

Comment thread docs/syntax/icons.md
Copy link
Copy Markdown
Member Author

@florent-leborgne florent-leborgne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if the code rabbit review is accurate, I didn't have to do that the last time I updated icons. Please advise :)

Copy link
Copy Markdown
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cache is just to ensure we can use them in frontend components.

@florent-leborgne florent-leborgne merged commit a400430 into main Apr 20, 2026
27 of 31 checks passed
@florent-leborgne florent-leborgne deleted the flb-icon-refresh-2025 branch April 20, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants