[5.x] Tag Cloud should deal with empty responses correctly#9368
Closed
elastic-jasper wants to merge 1 commit into5.xfrom
Closed
[5.x] Tag Cloud should deal with empty responses correctly#9368elastic-jasper wants to merge 1 commit into5.xfrom
elastic-jasper wants to merge 1 commit into5.xfrom
Conversation
Backports PR #9354 **Commit 1:** Tag Cloud should deal with empty responses correctly tag cloud did not work with empty responses correctly. One of the side-effects is that the back button did not work properly. For example, pressing the back button would not empty out the screen and show stale clouds. This also caused a type-error. Empty configurations meant that we could not access any aggregation-configs to produce a label. * Original sha: 9b52ba4 * Authored by Thomas Neirynck <thomas@elastic.co> on 2016-12-02T22:58:54Z
Contributor
|
closing this, must reopen new one after #9378 |
mgadewoll
added a commit
that referenced
this pull request
Apr 13, 2026
## Dependency updates - `@elastic/eui` - v114.0.0 ⏩ v114.1.0 - `@elastic/eslint-plugin-eui` - v2.11.0 ⏩ v2.11.1 --- ## Package updates ### @elastic/eui [`v114.1.0`](https://github.com/elastic/eui/releases/v114.1.0) - Added an optional `tooltipProps` prop to `EuiMarkdownEditorHelpButton` ([#9546](elastic/eui#9546)) - Added a warning when non-recommended units are used in `width`, `minWidth` or `maxWidth` props on `<EuiTableFooterCell>`, `<EuiTableHeaderCell>`, `<EuiTableHeaderCellCheckbox>` as well as the `columns` configuration on `<EuiBasicTable>` and `<EuiInMemoryTable>` ([#9540](elastic/eui#9540)) - Added `transitionBottomIn` and `transitionBottomOut` icons to `EuiIcon` ([#9528](elastic/eui#9528)) **Bug fixes** - Fixed `EuiFlyoutManager` animation flickering when switching between flyout sessions by removing intermediate transition stages (backgrounding, returning, closing) and limiting opening animations to the initial flyout and first child only ([#9514](elastic/eui#9514)) - Fixed rendering of `EuiTableHeaderMobile` when `responsiveBreakpoint=false` prop is set ([#9531](elastic/eui#9531)) ### @elastic/eslint-plugin-eui v2.11.1 **Bug fixes** - Fixed `no-css-color` ESLint rule crash when analyzing functions that return `undefined` or non-object values ([#9368](elastic/eui#9368)) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
michel-laterman
pushed a commit
to michel-laterman/kibana
that referenced
this pull request
Apr 13, 2026
## Dependency updates - `@elastic/eui` - v114.0.0 ⏩ v114.1.0 - `@elastic/eslint-plugin-eui` - v2.11.0 ⏩ v2.11.1 --- ## Package updates ### @elastic/eui [`v114.1.0`](https://github.com/elastic/eui/releases/v114.1.0) - Added an optional `tooltipProps` prop to `EuiMarkdownEditorHelpButton` ([elastic#9546](elastic/eui#9546)) - Added a warning when non-recommended units are used in `width`, `minWidth` or `maxWidth` props on `<EuiTableFooterCell>`, `<EuiTableHeaderCell>`, `<EuiTableHeaderCellCheckbox>` as well as the `columns` configuration on `<EuiBasicTable>` and `<EuiInMemoryTable>` ([elastic#9540](elastic/eui#9540)) - Added `transitionBottomIn` and `transitionBottomOut` icons to `EuiIcon` ([elastic#9528](elastic/eui#9528)) **Bug fixes** - Fixed `EuiFlyoutManager` animation flickering when switching between flyout sessions by removing intermediate transition stages (backgrounding, returning, closing) and limiting opening animations to the initial flyout and first child only ([elastic#9514](elastic/eui#9514)) - Fixed rendering of `EuiTableHeaderMobile` when `responsiveBreakpoint=false` prop is set ([elastic#9531](elastic/eui#9531)) ### @elastic/eslint-plugin-eui v2.11.1 **Bug fixes** - Fixed `no-css-color` ESLint rule crash when analyzing functions that return `undefined` or non-object values ([elastic#9368](elastic/eui#9368)) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tag Cloud should deal with empty responses correctly
Backports PR #9354
Commit 1:
Tag Cloud should deal with empty responses correctly
tag cloud did not work with empty responses correctly. One of the side-effects is that the back button did not work properly. For example, pressing the back button would not empty out the screen and show stale clouds.
This also caused a type-error. Empty configurations meant that we could not access any aggregation-configs to produce a label.