Skip to content

[EuiTable] Fix rendering of EuiTableHeaderMobile when responsiveBreakpoint=false#9531

Merged
tkajtoch merged 2 commits intoelastic:mainfrom
tkajtoch:fix/responsive-breakpoint-select-all-rows
Apr 1, 2026
Merged

[EuiTable] Fix rendering of EuiTableHeaderMobile when responsiveBreakpoint=false#9531
tkajtoch merged 2 commits intoelastic:mainfrom
tkajtoch:fix/responsive-breakpoint-select-all-rows

Conversation

@tkajtoch
Copy link
Copy Markdown
Member

@tkajtoch tkajtoch commented Mar 25, 2026

Summary

This PR fixes a bug I accidentally introduced recently while refactoring the component defaults logic in EuiTableHeaderMobile. The issue was caused by using || instead of ?? to determine whether to use the responsiveBreakpoint prop value or the same value coming from component defaults. I did not account for the fact that responsiveBreakpoint can also be false.

API Changes

No API changes

Impact Assessment

  • 🔴 Breaking changes — What will break? How many usages in Kibana/Cloud UI are impacted?
  • 💅 Visual changes — May impact style overrides; could require visual testing. Explain and estimate impact.
  • 🧪 Test impact — May break functional or snapshot tests (e.g., HTML structure, class names, default values).
  • 🔧 Hard to integrate — If integration is complex, stage commits in Kibana/Cloud UI branches for cherry-picking and link to them below.

Impact level: (very) 🟢 Low

This PR brings back old functionality and to my knowledge doesn't affect any Kibana snapshots, but I'm marking it as possible to affect test snapshots.

Release Readiness

  • Documentation: {link to docs page(s)}
  • Figma: {link to Figma or issue}
  • Migration guide: {steps or link, for breaking/visual changes or deprecations}
  • Adoption plan (new features): {link to issue/doc or outline who will integrate this and where}

QA instructions for reviewer

  • Open the EuiTableHeaderMobile story (PR, main), set responsiveBreakpoint to false and confirm that the "mobile header content" text isn't visible on any resolution by resizing the story window

Checklist before marking Ready for Review

Reviewer checklist

  • Approved Impact Assessment — Acceptable to merge given the consumer impact.
  • Approved Release Readiness — Docs, Figma, and migration info are sufficient to ship.

…component defaults if `responsiveBreakpoint` prop is set to `false`
@tkajtoch tkajtoch self-assigned this Mar 25, 2026
@elasticmachine
Copy link
Copy Markdown
Collaborator

💚 Build Succeeded

cc @tkajtoch

@elasticmachine
Copy link
Copy Markdown
Collaborator

💚 Build Succeeded

cc @tkajtoch

@tkajtoch tkajtoch marked this pull request as ready for review March 31, 2026 20:59
@tkajtoch tkajtoch requested a review from a team as a code owner March 31, 2026 20:59
Copy link
Copy Markdown
Contributor

@weronikaolejniczak weronikaolejniczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in prod and staging, code makes sense, thanks for the quick fix! 🟢

@tkajtoch tkajtoch merged commit fe7d873 into elastic:main Apr 1, 2026
6 checks passed
weronikaolejniczak pushed a commit to weronikaolejniczak/eui that referenced this pull request Apr 7, 2026
weronikaolejniczak pushed a commit to weronikaolejniczak/eui that referenced this pull request Apr 7, 2026
mgadewoll added a commit to elastic/kibana that referenced this pull request Apr 13, 2026
## Dependency updates

- `@elastic/eui` - v114.0.0 ⏩ v114.1.0
- `@elastic/eslint-plugin-eui` - v2.11.0 ⏩ v2.11.1

---

## Package updates

### @elastic/eui
[`v114.1.0`](https://github.com/elastic/eui/releases/v114.1.0)

- Added an optional `tooltipProps` prop to `EuiMarkdownEditorHelpButton`
([#9546](elastic/eui#9546))
- Added a warning when non-recommended units are used in `width`,
`minWidth` or `maxWidth` props on `<EuiTableFooterCell>`,
`<EuiTableHeaderCell>`, `<EuiTableHeaderCellCheckbox>` as well as the
`columns` configuration on `<EuiBasicTable>` and `<EuiInMemoryTable>`
([#9540](elastic/eui#9540))
- Added `transitionBottomIn` and `transitionBottomOut` icons to
`EuiIcon` ([#9528](elastic/eui#9528))

**Bug fixes**

- Fixed `EuiFlyoutManager` animation flickering when switching between
flyout sessions by removing intermediate transition stages
(backgrounding, returning, closing) and limiting opening animations to
the initial flyout and first child only
([#9514](elastic/eui#9514))
- Fixed rendering of `EuiTableHeaderMobile` when
`responsiveBreakpoint=false` prop is set
([#9531](elastic/eui#9531))

### @elastic/eslint-plugin-eui v2.11.1

**Bug fixes**

- Fixed `no-css-color` ESLint rule crash when analyzing functions that
return `undefined` or non-object values
([#9368](elastic/eui#9368))

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
michel-laterman pushed a commit to michel-laterman/kibana that referenced this pull request Apr 13, 2026
## Dependency updates

- `@elastic/eui` - v114.0.0 ⏩ v114.1.0
- `@elastic/eslint-plugin-eui` - v2.11.0 ⏩ v2.11.1

---

## Package updates

### @elastic/eui
[`v114.1.0`](https://github.com/elastic/eui/releases/v114.1.0)

- Added an optional `tooltipProps` prop to `EuiMarkdownEditorHelpButton`
([elastic#9546](elastic/eui#9546))
- Added a warning when non-recommended units are used in `width`,
`minWidth` or `maxWidth` props on `<EuiTableFooterCell>`,
`<EuiTableHeaderCell>`, `<EuiTableHeaderCellCheckbox>` as well as the
`columns` configuration on `<EuiBasicTable>` and `<EuiInMemoryTable>`
([elastic#9540](elastic/eui#9540))
- Added `transitionBottomIn` and `transitionBottomOut` icons to
`EuiIcon` ([elastic#9528](elastic/eui#9528))

**Bug fixes**

- Fixed `EuiFlyoutManager` animation flickering when switching between
flyout sessions by removing intermediate transition stages
(backgrounding, returning, closing) and limiting opening animations to
the initial flyout and first child only
([elastic#9514](elastic/eui#9514))
- Fixed rendering of `EuiTableHeaderMobile` when
`responsiveBreakpoint=false` prop is set
([elastic#9531](elastic/eui#9531))

### @elastic/eslint-plugin-eui v2.11.1

**Bug fixes**

- Fixed `no-css-color` ESLint rule crash when analyzing functions that
return `undefined` or non-object values
([elastic#9368](elastic/eui#9368))

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
weronikaolejniczak pushed a commit to weronikaolejniczak/eui that referenced this pull request May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants