chore(eslint-plugin): update typescript packages #8669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weronikaolejniczak
force-pushed
the
8668-update-typescript-packages-in-eslint-plugin
branch
from
010a8a1 to
f45e072
Compare
Collaborator
💚 Build Succeeded |
Collaborator
💚 Build Succeeded
History |
acstll
approved these changes
May 5, 2025
Contributor
acstll
left a comment
acstll
left a comment
There was a problem hiding this comment.
I verified commands run as expected locally, and the warning is gone :)
weronikaolejniczak
added a commit
to elastic/kibana
that referenced
this pull request
Jun 3, 2025
`@elastic/eslint-plugin-eui`: `0.2.0` ⏩ `1.0.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Changes This PR updates the `@elastic/eslint-plugin-eui` version to latest: [v1.0.0](https://www.npmjs.com/package/@elastic/eslint-plugin-eui/v/1.0.0). ## Package updates ### `@elastic/eslint-plugin-eui` - Changed the `prefer-css-prop-for-static-styles` rule message (formerly `prefer-css-attribute-for-eui-components`) ([#8722](elastic/eui#8722)) **Breaking changes** - Renamed the rule from `prefer-css-attribute-for-eui-components` to `prefer-css-prop-for-static-styles` to align with Emotion's best practice guidelines ([#8722](elastic/eui#8722)) **Dependency updates** - Updated `typescript` to v5.8.3 ([#8669](elastic/eui#8669)) - Updated `@typescript-eslint/eslint-plugin` to v8.31.1 ([#8669](elastic/eui#8669)) - Updated `@typescript-eslint/parser` to v8.31.1 ([#8669](elastic/eui#8669)) - Updated `@typescript-eslint/rule-tester` to v8.31.1 ([#8669](elastic/eui#8669)) - Updated `@typescript-eslint/typescript-estree` to v8.31.1 ([#8669](elastic/eui#8669)) - Updated `@typescript-eslint/utils` to v8.31.1 ([#8669](elastic/eui#8669))
zacharyparikh
pushed a commit
to zacharyparikh/kibana
that referenced
this pull request
Jun 4, 2025
`@elastic/eslint-plugin-eui`: `0.2.0` ⏩ `1.0.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Changes This PR updates the `@elastic/eslint-plugin-eui` version to latest: [v1.0.0](https://www.npmjs.com/package/@elastic/eslint-plugin-eui/v/1.0.0). ## Package updates ### `@elastic/eslint-plugin-eui` - Changed the `prefer-css-prop-for-static-styles` rule message (formerly `prefer-css-attribute-for-eui-components`) ([elastic#8722](elastic/eui#8722)) **Breaking changes** - Renamed the rule from `prefer-css-attribute-for-eui-components` to `prefer-css-prop-for-static-styles` to align with Emotion's best practice guidelines ([elastic#8722](elastic/eui#8722)) **Dependency updates** - Updated `typescript` to v5.8.3 ([elastic#8669](elastic/eui#8669)) - Updated `@typescript-eslint/eslint-plugin` to v8.31.1 ([elastic#8669](elastic/eui#8669)) - Updated `@typescript-eslint/parser` to v8.31.1 ([elastic#8669](elastic/eui#8669)) - Updated `@typescript-eslint/rule-tester` to v8.31.1 ([elastic#8669](elastic/eui#8669)) - Updated `@typescript-eslint/typescript-estree` to v8.31.1 ([elastic#8669](elastic/eui#8669)) - Updated `@typescript-eslint/utils` to v8.31.1 ([elastic#8669](elastic/eui#8669))
nickpeihl
pushed a commit
to nickpeihl/kibana
that referenced
this pull request
Jun 12, 2025
`@elastic/eslint-plugin-eui`: `0.2.0` ⏩ `1.0.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Changes This PR updates the `@elastic/eslint-plugin-eui` version to latest: [v1.0.0](https://www.npmjs.com/package/@elastic/eslint-plugin-eui/v/1.0.0). ## Package updates ### `@elastic/eslint-plugin-eui` - Changed the `prefer-css-prop-for-static-styles` rule message (formerly `prefer-css-attribute-for-eui-components`) ([elastic#8722](elastic/eui#8722)) **Breaking changes** - Renamed the rule from `prefer-css-attribute-for-eui-components` to `prefer-css-prop-for-static-styles` to align with Emotion's best practice guidelines ([elastic#8722](elastic/eui#8722)) **Dependency updates** - Updated `typescript` to v5.8.3 ([elastic#8669](elastic/eui#8669)) - Updated `@typescript-eslint/eslint-plugin` to v8.31.1 ([elastic#8669](elastic/eui#8669)) - Updated `@typescript-eslint/parser` to v8.31.1 ([elastic#8669](elastic/eui#8669)) - Updated `@typescript-eslint/rule-tester` to v8.31.1 ([elastic#8669](elastic/eui#8669)) - Updated `@typescript-eslint/typescript-estree` to v8.31.1 ([elastic#8669](elastic/eui#8669)) - Updated `@typescript-eslint/utils` to v8.31.1 ([elastic#8669](elastic/eui#8669))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #8668
On this PR, I address the comment from TypeScript update PR, regarding a warning on running
yarn lint:QA
Testing screenshots
In EUI:
In Kibana:
yarn workspace @elastic/eui lint, there should be no warning regarding@typescript-eslint/typescript-estreeyarn workspace @elastic/eslint-plugin-eui test, all unit tests should passyarn workspace @elastic/eslint-plugin-eui build, the package should build with no errors@elastic/eslint-plugin-euiare correct