feat(eslint-plugin): update prefer-css-attribute-for-eui-components rule #8722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weronikaolejniczak
force-pushed
the
8708-eslint-prefer-css-attributes-rule-is-warning-against-best-practice
branch
from
ed01d41 to
dc00cef
Compare
packages/eslint-plugin/src/rules/prefer_css_prop_for_static_styles.ts
Outdated
Show resolved
Hide resolved
acstll
reviewed
May 29, 2025
acstll
reviewed
Jun 2, 2025
Contributor
acstll
left a comment
acstll
left a comment
There was a problem hiding this comment.
I ran tests locally and went thru them. Also did manually test the package locally. And found no typos in the warning message. Everything working as expected 🟢
Only one comment regarding the changelog…
acstll
approved these changes
Jun 2, 2025
Contributor
acstll
left a comment
acstll
left a comment
There was a problem hiding this comment.
Thanks for the quick update! 🌊🚢
…rning-against-best-practice
Collaborator
💚 Build SucceededHistory
|
Collaborator
💚 Build Succeeded
History
|
weronikaolejniczak
added a commit
to elastic/kibana
that referenced
this pull request
Jun 3, 2025
`@elastic/eslint-plugin-eui`: `0.2.0` ⏩ `1.0.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Changes This PR updates the `@elastic/eslint-plugin-eui` version to latest: [v1.0.0](https://www.npmjs.com/package/@elastic/eslint-plugin-eui/v/1.0.0). ## Package updates ### `@elastic/eslint-plugin-eui` - Changed the `prefer-css-prop-for-static-styles` rule message (formerly `prefer-css-attribute-for-eui-components`) ([#8722](elastic/eui#8722)) **Breaking changes** - Renamed the rule from `prefer-css-attribute-for-eui-components` to `prefer-css-prop-for-static-styles` to align with Emotion's best practice guidelines ([#8722](elastic/eui#8722)) **Dependency updates** - Updated `typescript` to v5.8.3 ([#8669](elastic/eui#8669)) - Updated `@typescript-eslint/eslint-plugin` to v8.31.1 ([#8669](elastic/eui#8669)) - Updated `@typescript-eslint/parser` to v8.31.1 ([#8669](elastic/eui#8669)) - Updated `@typescript-eslint/rule-tester` to v8.31.1 ([#8669](elastic/eui#8669)) - Updated `@typescript-eslint/typescript-estree` to v8.31.1 ([#8669](elastic/eui#8669)) - Updated `@typescript-eslint/utils` to v8.31.1 ([#8669](elastic/eui#8669))
zacharyparikh
pushed a commit
to zacharyparikh/kibana
that referenced
this pull request
Jun 4, 2025
`@elastic/eslint-plugin-eui`: `0.2.0` ⏩ `1.0.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Changes This PR updates the `@elastic/eslint-plugin-eui` version to latest: [v1.0.0](https://www.npmjs.com/package/@elastic/eslint-plugin-eui/v/1.0.0). ## Package updates ### `@elastic/eslint-plugin-eui` - Changed the `prefer-css-prop-for-static-styles` rule message (formerly `prefer-css-attribute-for-eui-components`) ([elastic#8722](elastic/eui#8722)) **Breaking changes** - Renamed the rule from `prefer-css-attribute-for-eui-components` to `prefer-css-prop-for-static-styles` to align with Emotion's best practice guidelines ([elastic#8722](elastic/eui#8722)) **Dependency updates** - Updated `typescript` to v5.8.3 ([elastic#8669](elastic/eui#8669)) - Updated `@typescript-eslint/eslint-plugin` to v8.31.1 ([elastic#8669](elastic/eui#8669)) - Updated `@typescript-eslint/parser` to v8.31.1 ([elastic#8669](elastic/eui#8669)) - Updated `@typescript-eslint/rule-tester` to v8.31.1 ([elastic#8669](elastic/eui#8669)) - Updated `@typescript-eslint/typescript-estree` to v8.31.1 ([elastic#8669](elastic/eui#8669)) - Updated `@typescript-eslint/utils` to v8.31.1 ([elastic#8669](elastic/eui#8669))
nickpeihl
pushed a commit
to nickpeihl/kibana
that referenced
this pull request
Jun 12, 2025
`@elastic/eslint-plugin-eui`: `0.2.0` ⏩ `1.0.0` [Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams) ## Changes This PR updates the `@elastic/eslint-plugin-eui` version to latest: [v1.0.0](https://www.npmjs.com/package/@elastic/eslint-plugin-eui/v/1.0.0). ## Package updates ### `@elastic/eslint-plugin-eui` - Changed the `prefer-css-prop-for-static-styles` rule message (formerly `prefer-css-attribute-for-eui-components`) ([elastic#8722](elastic/eui#8722)) **Breaking changes** - Renamed the rule from `prefer-css-attribute-for-eui-components` to `prefer-css-prop-for-static-styles` to align with Emotion's best practice guidelines ([elastic#8722](elastic/eui#8722)) **Dependency updates** - Updated `typescript` to v5.8.3 ([elastic#8669](elastic/eui#8669)) - Updated `@typescript-eslint/eslint-plugin` to v8.31.1 ([elastic#8669](elastic/eui#8669)) - Updated `@typescript-eslint/parser` to v8.31.1 ([elastic#8669](elastic/eui#8669)) - Updated `@typescript-eslint/rule-tester` to v8.31.1 ([elastic#8669](elastic/eui#8669)) - Updated `@typescript-eslint/typescript-estree` to v8.31.1 ([elastic#8669](elastic/eui#8669)) - Updated `@typescript-eslint/utils` to v8.31.1 ([elastic#8669](elastic/eui#8669))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #8708
On this PR, I:
prefer-css-attribute-for-eui-componentstoprefer-css-prop-for-static-stylesto highlight the case we're concerned with,eui-componentsis a redundancy when the rule comes from EUI ESLint plugin andcssis technically a "prop" and not an "attribute" (it's not a regular HTML attribute),something!) to actually assert if the range is truthy before passing it tofixer.replaceTextRange,cssprop instead ofstylefor static styles in EUI components to ensure better performance and consistency with EUI’s styling approach.". I'm open to any suggestions that could make it better 🙏🏻I consider this a breaking change because
prefer-css-attribute-for-eui-componentsis technically no longer available.QA
Testing instructions