Skip to content

Conversation

@weronikaolejniczak
Copy link
Contributor

@weronikaolejniczak weronikaolejniczak commented Jun 12, 2025

@elastic/eslint-plugin-eui: 1.0.02.0.0

Questions? Please see our Kibana upgrade FAQ.

Changes

This PR updates the @elastic/eslint-plugin-eui version to latest: v2.0.0.

Package updates

@elastic/eslint-plugin-eui

Breaking changes

  • Remove prefer-css-prop-for-static-styles rule because it produces too many warnings. Static code analysis cannot flag dynamic styles with confidence because it doesn't run the code to asses runtime values. We will explore runtime solutions. (#8760)

@weronikaolejniczak weronikaolejniczak self-assigned this Jun 12, 2025
@weronikaolejniczak weronikaolejniczak added release_note:skip Skip the PR/issue when compiling release notes EUI backport:skip This PR does not require backporting labels Jun 12, 2025
@weronikaolejniczak weronikaolejniczak force-pushed the eslint-plugin-eui-v2.0.0 branch 2 times, most recently from 80019c5 to 3fe80ef Compare June 12, 2025 10:02
@weronikaolejniczak weronikaolejniczak marked this pull request as ready for review June 12, 2025 10:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/eui-team (EUI)

@weronikaolejniczak weronikaolejniczak requested a review from a team as a code owner June 12, 2025 10:49
Copy link
Contributor

@albertoblaz albertoblaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too bad, but when you folks nail this, it will help us a lot 🚀

@weronikaolejniczak weronikaolejniczak force-pushed the eslint-plugin-eui-v2.0.0 branch from e73413b to feb5acb Compare June 12, 2025 13:45
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #87 / ESQL execution logic API @ess @serverless ES|QL rule type, alert suppression with exceptions should apply exceptions

Metrics [docs]

Unknown metric groups

ESLint disabled line counts

id before after diff
securitySolution 610 609 -1

Total ESLint disabled count

id before after diff
securitySolution 704 703 -1

History

cc @weronikaolejniczak

@weronikaolejniczak weronikaolejniczak force-pushed the eslint-plugin-eui-v2.0.0 branch from feb5acb to eb14f52 Compare June 12, 2025 16:04
@weronikaolejniczak weronikaolejniczak removed the request for review from tsullivan June 12, 2025 16:21
@weronikaolejniczak weronikaolejniczak force-pushed the eslint-plugin-eui-v2.0.0 branch 2 times, most recently from e52dfcc to 54ef4f6 Compare June 12, 2025 16:36
@weronikaolejniczak weronikaolejniczak enabled auto-merge (squash) June 12, 2025 16:44
@weronikaolejniczak weronikaolejniczak force-pushed the eslint-plugin-eui-v2.0.0 branch from 54ef4f6 to 3d301fb Compare June 13, 2025 06:14
@weronikaolejniczak weronikaolejniczak merged commit 1f5a60e into elastic:main Jun 13, 2025
11 checks passed
iblancof pushed a commit to iblancof/kibana that referenced this pull request Jun 16, 2025
`@elastic/eslint-plugin-eui`: `1.0.0` ⏩ `2.0.0`

[Questions? Please see our Kibana upgrade
FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)

## Changes

This PR updates the `@elastic/eslint-plugin-eui` version to latest:
[v2.0.0](https://www.npmjs.com/package/@elastic/eslint-plugin-eui/v/2.0.0).

## Package updates



### `@elastic/eslint-plugin-eui`

**Breaking changes**

- Remove `prefer-css-prop-for-static-styles` rule because it produces
too many warnings. Static code analysis cannot flag dynamic styles with
confidence because it doesn't run the code to asses runtime values. We
will explore runtime solutions.
([elastic#8760](elastic/eui#8760))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting EUI release_note:skip Skip the PR/issue when compiling release notes v9.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants