-
Notifications
You must be signed in to change notification settings - Fork 8.5k
chore: update eslint-plugin-eui to 0.1.1 #210082
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update eslint-plugin-eui to 0.1.1 #210082
Conversation
62fc504 to
b0e895a
Compare
d06195f to
25e504b
Compare
85dd123 to
ae75b43
Compare
|
I have a PR open (elastic/eui#8524) with the fix for:
I will release a patch version and update this PR. EDIT: Done on 347a4e5 |
e4cb634 to
347a4e5
Compare
💔 Build Failed
Failed CI StepsHistory
|
eokoneyo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@elastic/security-generative-ai could you take a look? I only changed the eslint-disable comments in your source 😄 |
|
🚢 @weronikaolejniczak :) |



Summary
Bring in the changes from elastic/eui#8304, specifically ESLint rules:
no-restricted-eui-importsno-css-color(migrated from@kbn/eslint-plugin-css)prefer-css-attribute-for-eui-components(migrated from@kbn/eslint-plugin-css)Relates to elastic/eui#8201, https://github.com/elastic/eui-private/issues/275
QA
Instructions
gh pr checkout 210082.yarn kbn bootstrap.Test cases
no-restricted-eui-importsExample files:
src/platform/packages/shared/kbn-ui-theme/src/theme.ts@kbn/ui-theme:src/platform/plugins/private/vis_types/vega/public/data_model/utils.tsno-css-colorExample file:
src/platform/plugins/shared/kibana_react/public/page_template/no_data_page/no_data_card/elastic_agent_card.tsx:50prefer-css-attribute-for-eui-componentsExample file:
x-pack/examples/alerting_example/public/alert_types/always_firing.tsx:166