[Docs only] Fix EuiFilePicker example file list on Firefox#5064
Merged
cee-chen merged 1 commit intoelastic:masterfrom Aug 23, 2021
Merged
[Docs only] Fix EuiFilePicker example file list on Firefox#5064cee-chen merged 1 commit intoelastic:masterfrom
cee-chen merged 1 commit intoelastic:masterfrom
Conversation
cee-chen
added
the
skip-changelog
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5064/ |
Contributor
Author
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5064/ |
Contributor
Author
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5064/ |
thompsongl
approved these changes
Aug 23, 2021
Contributor
thompsongl
left a comment
thompsongl
left a comment
There was a problem hiding this comment.
Good catch ⚾ Confirmed with the docs preview build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I noticed this while QA testing #5063 locally - my file list in the file picker doc example wasn't updating when I added/updated existing files, only on new file add:
(note how
trialdoes not update to matchgold, and 3 files are listed in the picker but not on the right)After some digging, this appears to be because I'm a Firefox user, and Firefox for some reason is mutating the existing FileList in place, which fails to trigger a React state change 🤦♀️ (facebook/react#18104)
There's a relatively simple
Array.from(FileList)workaround you can use to correctly trigger state changes, which I thought was worth implementing both to fix this behavior and as an example to other dev users who may run into the same issue at some point in the future 🤷Fixed behavior on FF:
Checklist
- [ ] Check against all themes for compatibility in both light and dark modes- [ ] Checked in mobile- [ ] Props have proper autodocs and playground toggles- [ ] Checked Code Sandbox works for the any docs examples- [ ] Added or updated jest tests- [ ] Checked for breaking changes and labeled appropriately- [ ] Checked for accessibility including keyboard-only and screenreader modes- [ ] A changelog entry exists and is marked appropriately