Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
| export const EuiRange: FunctionComponent< | ||
| CommonProps & InputHTMLAttributes<HTMLInputElement> & EuiRangeProps | ||
| CommonProps & | ||
| Omit<InputHTMLAttributes<HTMLInputElement>, 'onChange'> & |
There was a problem hiding this comment.
In case if we don't omit onChange def from InputHTMLAttributes<HTMLInputElement>, EuiRange's onChange requires ((event: React.ChangeEvent<HTMLInputElement>) => void) & ((event: React.ChangeEvent<HTMLInputElement> | React.MouseEvent<HTMLButtonElement, MouseEvent>, isValid: boolean) => void)) def.
|
@chandlerprall getting back to the comment #2211 (comment), |
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM, created an empty typescript project locally, added EUI as a dependency, and verified the bug before this change and that it is fixed with this it.
Needs a bugfix entry to CHANGELOG.md before merging
|
jenkins test this |
|
You can access if (e.currentTarget instanceof HTMLInputElement) {
... do something with e.currentTarget.valueAsNumber ...
} |
chandlerprall
left a comment
There was a problem hiding this comment.
Changes LGTM! Tested locally by consuming change in an new TS project
Summary
This PR updates TS def for
onChangemethod ofEuiRange.