Merged
Conversation
cchaos
added
v8.0.0
release_note:skip
Contributor
Author
Code owners:I fixed 2 things:
|
chandlerprall
approved these changes
Sep 18, 2019
Contributor
chandlerprall
left a comment
chandlerprall
left a comment
There was a problem hiding this comment.
package.json, yarn.lock, and snapshots changes LGTM
code changes look sane
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
Author
|
@chandlerprall I'm so sorry, I rebased with master but forgot to pull down your commit first and it obliterated your fix. Do you mind pushing again? |
Contributor
💔 Build Failed |
Contributor
|
@cchaos pushed up again! |
Contributor
Author
|
THANK YOU!!! |
Contributor
💚 Build Succeeded |
cchaos
added a commit
to cchaos/kibana
that referenced
this pull request
Sep 19, 2019
* Upgraded EUI to 14.2.0 * Remove form row + button shim * Uncomment compressed prop from EuiComboBoxes * Fix and/or simplify prepend/append usages * Update two test files to correctly call EuiRange's onChange prop
cchaos
added a commit
that referenced
this pull request
Sep 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
14.2.0compressedoption tobuttonSizeprop of EuiButtonGroup (#2343)EuiCard,EuiKeyPadMenuItemandEuiKeyPadMenuItemButton(#2333)
compressedTS definitions toEuiComboBox,EuiCheckboxGroup,EuiCheckbox,EuiFieldSearch,EuiRadioGroup,EuiSwitch(#2338)EuiFormRowandEuiButton(#2338)[readOnly]inputs (#2338)Bug fixes
onChangeTS defs for EuiRange (#2349)EuiPopover(#2341)prependandappendnodes that may be popovers or tooltips (#2338)14.1.1Bug fixes
14.1.0EuiSuggestcomponent (#2270)compressedstyling toEuiSwitch(#2327)EuiBottomBar,EuiHealthandEuiImageto TS (#2328)allowFullScreenis true inEuiImage(#2287)EuiColorPickerto TypeScript (#2340)EuiColorPicker(#2340)Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately