Skip to content

RangeOption: Get rid of ts-ignore #45902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maryia-lapata merged 5 commits into from
Sep 24, 2019
Merged

RangeOption: Get rid of ts-ignore #45902

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7b21978
Get rid of ts-ignore
maryia-lapata Sep 17, 2019
1b661f1
Update range.tsx
maryia-lapata Sep 18, 2019
9af9d1f
Merge branch 'master' of github.com:elastic/kibana into small-fixes
maryia-lapata Sep 20, 2019
98da1a5
Merge branch 'master' into small-fixes
elasticmachine Sep 23, 2019
9bf8e35
Refactoring
maryia-lapata Sep 23, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/legacy/core_plugins/kbn_vislib_vis_types/public/components/common/range.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
*/

import React, { useState } from 'react';
import { EuiFormRow, EuiRange } from '@elastic/eui';
import { EuiFormRow, EuiRange, EuiRangeProps } from '@elastic/eui';
import { i18n } from '@kbn/i18n';

interface RangeOptionProps<ParamName extends string> {
Expand Down Expand Up @@ -50,10 +50,9 @@ function RangeOption<ParamName extends string>({
values: { min, max },
});

const onChangeHandler = (
{ target: { valueAsNumber } }: React.ChangeEvent<HTMLInputElement>,
isValid: boolean
) => {
const onChangeHandler: EuiRangeProps['onChange'] = (event, isValid) => {
const { valueAsNumber } = event.target as HTMLInputElement; // since we don't show ticks on EuiRange, the target will definitely be HTMLInputElement type, so we can cast it directly.

setStateValue(valueAsNumber);
setIsValidState(isValid);

Expand All @@ -72,7 +71,6 @@ function RangeOption<ParamName extends string>({
showInput={showInput}
step={step}
value={stateValue}
// @ts-ignore
onChange={onChangeHandler}
/>
</EuiFormRow>
Expand Down