Skip to content

Range TS #2349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chandlerprall merged 4 commits into from
Sep 17, 2019
Merged

Range TS #2349

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ebf63eb
Fix TS
maryia-lapata Sep 17, 2019
c398aaa
Update CHANGELOG.md
maryia-lapata Sep 17, 2019
a825772
Update CHANGELOG.md
maryia-lapata Sep 17, 2019
ea0ad34
Merge branch 'master' into range-onchange
chandlerprall Sep 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

No public interface changes since `14.1.0`.
Comment thread
chandlerprall marked this conversation as resolved.
Outdated

**Bug fixes**

- Fixed `onChange` TS defs for EuiRange ([#2349](https://github.com/elastic/eui/pull/2349))

## [`14.1.0`](https://github.com/elastic/eui/tree/v14.1.0)

- Created `EuiSuggest` component ([#2270](https://github.com/elastic/eui/pull/2270))
Expand Down
4 changes: 3 additions & 1 deletion src/components/form/range/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,9 @@ declare module '@elastic/eui' {
}

export const EuiRange: FunctionComponent<
CommonProps & InputHTMLAttributes<HTMLInputElement> & EuiRangeProps
CommonProps &
Omit<InputHTMLAttributes<HTMLInputElement>, 'onChange'> &

@maryia-lapata maryia-lapata Sep 17, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case if we don't omit onChange def from InputHTMLAttributes<HTMLInputElement>, EuiRange's onChange requires ((event: React.ChangeEvent<HTMLInputElement>) => void) & ((event: React.ChangeEvent<HTMLInputElement> | React.MouseEvent<HTMLButtonElement, MouseEvent>, isValid: boolean) => void)) def.

EuiRangeProps
>;

/**
Expand Down