Skip to content

Explicitly set a confidence interval in more dense vector tests#145232

Merged
davidkyle merged 2 commits intoelastic:mainfrom
davidkyle:more-confidence-intervals
Mar 31, 2026
Merged

Explicitly set a confidence interval in more dense vector tests#145232
davidkyle merged 2 commits intoelastic:mainfrom
davidkyle:more-confidence-intervals

Conversation

@davidkyle
Copy link
Copy Markdown
Member

Follow on to #145078 which missed a few tests

Closes #145180

@davidkyle davidkyle added >test Issues or PRs that are addressing/adding tests :Search Relevance/Search Catch all for Search Relevance v9.4.0 labels Mar 30, 2026
@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Mar 30, 2026
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@benwtrent
Copy link
Copy Markdown
Member

I mean, if we are having to do this, there is obviously something wrong with how we serialize and handle default values.

If returning and "include_defaults" is true we should return 0 confidence interval in the mapping. I am supposing that mapping merges occur with defaults included to ensure merges can occur. Are we not doing this? I wonder if that simplifies all this mess?

Copy link
Copy Markdown
Contributor

@pmpailis pmpailis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for handling this to fix the failing tests!

( ++ on Ben's comment to handle this more gracefully; either here or in a follow up)

@davidkyle
Copy link
Copy Markdown
Member Author

The problem is the this assertion in DocumentMapper which is firing on the old node in a mixed cluster. For this mixed cluster problem we can't use a the usual solution of a creating node feature as this means passing the FeatureService and ClusterState down into the mapper. We can't change all the BWC versions so we were left with a choice of selective muting or setting confidence_interval to the old default value making the mapping representations the same in the new cluster and old cluster. This change is the latter and unfortunately that means we have to handle all the deprecation warning which trigger not just when setting the value at index creation but every time a document is indexed.

@davidkyle davidkyle merged commit e41b80e into elastic:main Mar 31, 2026
35 checks passed
@davidkyle
Copy link
Copy Markdown
Member Author

confidence_interval is deprecated, the new default value is for it to not exist

szybia added a commit to szybia/elasticsearch that referenced this pull request Mar 31, 2026
…rics

* upstream/main: (428 commits)
  ESQL: DS: Add inference/RERANK tests (elastic#145229)
  Unmute MMR logical plan test (elastic#145311)
  Do not attempt marking store as corrupted if the check is rejected due to shutdown (elastic#145209)
  feat(tsdb): add pipeline runtime and rename stage interfaces (elastic#145175)
  Fix UnresolvedException on PromQL by(step) grouping (elastic#145307)
  ES|QL: Optimize MMR by reducing cache size and lookup (elastic#145014)
  Prometheus labels/series APIs: support multiple match[] selectors (elastic#145298)
  Move ClientScrollablePaginatedHitSource into Reindex Module (elastic#144100)
  mute test class for elastic#145277
  CPS mode for ViewResolver (elastic#145219)
  [ESQL] Disables GroupedTopNBenchmark temporarily (elastic#145124)
  Make exponential_histogram the default histogram type for HTTP OTLP endpoint (elastic#145065)
  More tests requiring an explicit confidence interval (elastic#145232)
  ES|QL: Adding `USER_AGENT` command (elastic#144384)
  ESQL: enable Generative IT after more fixes (elastic#145112)
  Rework FieldMapper parameter tests to not use merge builders (elastic#145213)
  [ESQL] Fix ORC type support gaps (elastic#145074)
  [Test] Unmute FollowingEngineTests.testProcessOnceOnPrimary (elastic#145192)
  Add PrometheusSeriesRestAction for /_prometheus/api/v1/series endpoint (elastic#144494)
  Prometheus labels API: add rest action (elastic#144952)
  ...
ncordon pushed a commit to ncordon/elasticsearch that referenced this pull request Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Search Relevance/Search Catch all for Search Relevance Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch >test Issues or PRs that are addressing/adding tests v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] MixedClusterClientYamlTestSuiteIT class failing

4 participants