Explicitly set a confidence interval in dense vector tests#145078
Merged
davidkyle merged 2 commits intoelastic:mainfrom Mar 27, 2026
Merged
Explicitly set a confidence interval in dense vector tests#145078davidkyle merged 2 commits intoelastic:mainfrom
davidkyle merged 2 commits intoelastic:mainfrom
Conversation
elasticsearchmachine
added
v9.4.0
needs:triage
davidkyle
added
:Search Relevance/Search
elasticsearchmachine
added
the
Team:Search Relevance
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
This was referenced Mar 27, 2026
john-wagster
approved these changes
Mar 27, 2026
Contributor
john-wagster
left a comment
john-wagster
left a comment
There was a problem hiding this comment.
lgtm; i agree do this PR instead
davidkyle
changed the title
mamazzol
pushed a commit
to mamazzol/elasticsearch
that referenced
this pull request
Mar 30, 2026
…45078) Fix for the dense vector mixed cluster tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mixed cluster tests using int4_flat or int4_hnsw index options fail because
confidence_intervalpreviously defaulted to 0.0 but is now deprecated. This means when the value is unset versions before 9.4.0 write it out as 0.0 but after 9.4.0 the field is not written. The difference triggers an assertion in the DocumentMapper.The simple fix is to explicitly add the param into the tests so both versions have the same representation
Closes #144997.