Skip to content

[ESQL] Disables GroupedTopNBenchmark temporarily#145124

Merged
ncordon merged 10 commits intoelastic:mainfrom
ncordon:speedup-grouped-topn-bench
Mar 31, 2026
Merged

[ESQL] Disables GroupedTopNBenchmark temporarily#145124
ncordon merged 10 commits intoelastic:mainfrom
ncordon:speedup-grouped-topn-bench

Conversation

@ncordon
Copy link
Copy Markdown
Member

@ncordon ncordon commented Mar 27, 2026

Disables the GroupedTopNBenchmark temporarily because it's making the micro-benchmark jobs fail due to a combinatorial explossion of parameters we are trying out:

GroupedTopNBenchmark: data(5) × topCount(3) × groupCount(3) × groupKeys(5) = 225 combinations 

The failing builds are here 😢: https://buildkite.com/elastic/elasticsearch-periodic-micro-benchmarks.

Part of https://github.com/elastic/esql-planning/issues/237

@ncordon ncordon added >bug >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) :Analytics/ES|QL AKA ESQL v9.4.0 labels Mar 27, 2026
@ncordon ncordon marked this pull request as ready for review March 27, 2026 17:48
@elasticsearchmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@ncordon ncordon enabled auto-merge (squash) March 27, 2026 17:50
Copy link
Copy Markdown
Contributor

@julian-elastic julian-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to temporarily disable so stop failing

@ncordon ncordon disabled auto-merge March 30, 2026 07:48
@ncordon ncordon enabled auto-merge (squash) March 30, 2026 07:49
@ncordon ncordon merged commit de2ead3 into elastic:main Mar 31, 2026
35 checks passed
szybia added a commit to szybia/elasticsearch that referenced this pull request Mar 31, 2026
…rics

* upstream/main: (428 commits)
  ESQL: DS: Add inference/RERANK tests (elastic#145229)
  Unmute MMR logical plan test (elastic#145311)
  Do not attempt marking store as corrupted if the check is rejected due to shutdown (elastic#145209)
  feat(tsdb): add pipeline runtime and rename stage interfaces (elastic#145175)
  Fix UnresolvedException on PromQL by(step) grouping (elastic#145307)
  ES|QL: Optimize MMR by reducing cache size and lookup (elastic#145014)
  Prometheus labels/series APIs: support multiple match[] selectors (elastic#145298)
  Move ClientScrollablePaginatedHitSource into Reindex Module (elastic#144100)
  mute test class for elastic#145277
  CPS mode for ViewResolver (elastic#145219)
  [ESQL] Disables GroupedTopNBenchmark temporarily (elastic#145124)
  Make exponential_histogram the default histogram type for HTTP OTLP endpoint (elastic#145065)
  More tests requiring an explicit confidence interval (elastic#145232)
  ES|QL: Adding `USER_AGENT` command (elastic#144384)
  ESQL: enable Generative IT after more fixes (elastic#145112)
  Rework FieldMapper parameter tests to not use merge builders (elastic#145213)
  [ESQL] Fix ORC type support gaps (elastic#145074)
  [Test] Unmute FollowingEngineTests.testProcessOnceOnPrimary (elastic#145192)
  Add PrometheusSeriesRestAction for /_prometheus/api/v1/series endpoint (elastic#144494)
  Prometheus labels API: add rest action (elastic#144952)
  ...
ncordon added a commit to ncordon/elasticsearch that referenced this pull request Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/ES|QL AKA ESQL >bug >non-issue Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants