Move ClientScrollablePaginatedHitSource into Reindex Module#144100
Merged
elasticsearchmachine merged 9 commits intoelastic:mainfrom Mar 31, 2026
Merged
Conversation
Moves ClientScrollablePaginatedHitSource from server/index/reindex into modules/reindex to be alongside classes it uses, and to be in the same package as its tests
joshua-adams-1
added
>non-issue
:Distributed/Reindex
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
szybia
reviewed
Mar 25, 2026
modules/reindex/src/main/java/org/elasticsearch/reindex/remote/RemoteResponseParsers.java
Outdated
Show resolved
Hide resolved
modules/reindex/src/main/java/org/elasticsearch/reindex/AbstractAsyncBulkByScrollAction.java
Outdated
Show resolved
Hide resolved
…hua-adams-1/elasticsearch into reindexing-move-paginated-hit-source
szybia
approved these changes
Mar 27, 2026
Contributor
szybia
left a comment
szybia
left a comment
There was a problem hiding this comment.
lgtm, my only concern is breaking serialization and i don't see anything here that should
curious what the failing tests are though 🤔
joshua-adams-1
added
the
auto-merge-without-approval
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Mar 31, 2026
…rics * upstream/main: (428 commits) ESQL: DS: Add inference/RERANK tests (elastic#145229) Unmute MMR logical plan test (elastic#145311) Do not attempt marking store as corrupted if the check is rejected due to shutdown (elastic#145209) feat(tsdb): add pipeline runtime and rename stage interfaces (elastic#145175) Fix UnresolvedException on PromQL by(step) grouping (elastic#145307) ES|QL: Optimize MMR by reducing cache size and lookup (elastic#145014) Prometheus labels/series APIs: support multiple match[] selectors (elastic#145298) Move ClientScrollablePaginatedHitSource into Reindex Module (elastic#144100) mute test class for elastic#145277 CPS mode for ViewResolver (elastic#145219) [ESQL] Disables GroupedTopNBenchmark temporarily (elastic#145124) Make exponential_histogram the default histogram type for HTTP OTLP endpoint (elastic#145065) More tests requiring an explicit confidence interval (elastic#145232) ES|QL: Adding `USER_AGENT` command (elastic#144384) ESQL: enable Generative IT after more fixes (elastic#145112) Rework FieldMapper parameter tests to not use merge builders (elastic#145213) [ESQL] Fix ORC type support gaps (elastic#145074) [Test] Unmute FollowingEngineTests.testProcessOnceOnPrimary (elastic#145192) Add PrometheusSeriesRestAction for /_prometheus/api/v1/series endpoint (elastic#144494) Prometheus labels API: add rest action (elastic#144952) ...
ncordon
pushed a commit
to ncordon/elasticsearch
that referenced
this pull request
Apr 1, 2026
…144100) Moves `PaginatedHitSource` and it's implementation `ClientScrollablePaginatedHitSource` from `server/index/reindex` into `modules/reindex` to be alongside it's remote implementation. This also aligns these classes with their tests. `PaginatedHitSource.SearchFailure` is also extracted into it's own class and kept in `server/index/reindex` since it is depended upon by workflows other than reindexing, but is renamed to `PaginatedSearchFailure` to be less ambiguous. Relates: elastic/elasticsearch-team#2088
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
PaginatedHitSourceand it's implementationClientScrollablePaginatedHitSourcefromserver/index/reindexintomodules/reindexto be alongside it's remote implementation. This also aligns these classes with their tests.PaginatedHitSource.SearchFailureis also extracted into it's own class and kept inserver/index/reindexsince it is depended upon by workflows other than reindexing, but is renamed toPaginatedSearchFailureto be less ambiguous.Relates: https://github.com/elastic/elasticsearch-team/issues/2088