Conversation
samxbr
force-pushed
the
reindex/add-list-api
branch
2 times, most recently
from
bbc0c9a to
6501fd7
Compare
samxbr
force-pushed
the
reindex/add-list-api
branch
from
6501fd7 to
5b41d77
Compare
samxbr
added
:Distributed/Reindex
elasticsearchmachine
added
the
Team:Distributed Indexing (obsolete)
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
|
I also want to add some multi-project tests to test project isolation. Syzmon is doing something similar in #139211 so holding it for now. |
PeteGillinElastic
left a comment
PeteGillinElastic
left a comment
There was a problem hiding this comment.
Thanks. Just a few small comments. Nice work!
...eindex-management/src/main/java/org/elasticsearch/reindex/management/GetReindexResponse.java
Outdated
Show resolved
Hide resolved
...eindex-management/src/main/java/org/elasticsearch/reindex/management/GetReindexResponse.java
Outdated
Show resolved
Hide resolved
| // Filter for only reindex tasks | ||
| if (ReindexAction.NAME.equals(task.getAction()) == false) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Optional: I think that we could call setActions(ReindexAction.NAME) in the constructor and omit this logic: the super.match call would include it. It would be fractionally slower because that supports simple match patterns on the action names. The benefit is that we're using the mechanism that already exists for filtering by action type.
There was a problem hiding this comment.
I actually tried calling setActions(ReindexAction.NAME) in constructor, but that gave a this-escape compilation warning, which I found it weird since setActions is a parent class method. It shouldn't be a concern in this case, and we could add @SuppressWarnings("this-escape") but I am not too happy about suppressing it.
More importantly, since the setActions() method is public, setting it in constructor doesn't give the class a guarantee it won't be overridden externally, so I added this check in the match to ensure the behaviour is correct even if the actions are overridden.
| // Filter out subtasks | ||
| if (task.getParentTaskId().isSet()) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
(Aside: It's a shame that the base class supports filtering to children of a specific parent, but not filtering only to non-child tasks...)
On second thought, I will merge this PR and add MP tests in a separate PR, since some code in this PR can be reused in other places. |
* upstream/main: Add hook for blocking termination (elastic#133555) Delegate to ES93ScalarQuantizedVectorsFormat rather than copying behaviour (elastic#139834) Refactor compound block types (elastic#140219) Flush the rate buffer when the slice index changes (elastic#138856) Log linked project connection errors at debug during shutdown (elastic#140239) Periodic FIPS 140-3 buildkite pipelines (elastic#139909) ES|QL - Remove TERM function (elastic#139953) Fix name of started time field in shutdown status (elastic#139910) Drop `project_routing` from query params (elastic#140272) Fix flaky test: AllocationDecidersTests (elastic#140271) Add List Reindex API (elastic#140184) Expose _tier metadata attribute in ESQL (elastic#139894) Tweak TSDBRestEsqlIT#testTimeSeriesQuerying(...) (elastic#140210) Fix an OOM error when creating to many chained synonym graph token filter. (elastic#140026) Suppress Azure SDK error logs (elastic#139730) Rewritten integer sorts need to use SortedNumericSortField (elastic#139538) (elastic#139700) Adjust index versions for skippers for time series (elastic#139670) Fix host.name skippers index version range (elastic#139636) Remove BWC shim for a broken commit Fix index.mapping.use_doc_values_skipper defaults in serverless (elastic#139532)
3 participants
Add a
GET /_reindexAPI to list all running reindex operation. The API is project-scoped (throughTransportTasksProjectAction) and only list parent reindex tasks.Closes https://github.com/elastic/elasticsearch-team/issues/2121