Skip to content

Fix host.name skippers index version range#139636

Merged
jordan-powers merged 2 commits intoelastic:patch/serverless-fixfrom
jordan-powers:fix-skippers-serverless-patch
Dec 16, 2025
Merged

Fix host.name skippers index version range#139636
jordan-powers merged 2 commits intoelastic:patch/serverless-fixfrom
jordan-powers:fix-skippers-serverless-patch

Conversation

@jordan-powers
Copy link
Contributor

No description provided.

@jordan-powers jordan-powers self-assigned this Dec 16, 2025
@jordan-powers jordan-powers added >non-issue :StorageEngine/Mapping The storage related side of mappings labels Dec 16, 2025
@elasticsearchmachine elasticsearchmachine added serverless-linked Added by automation, don't add manually Team:StorageEngine labels Dec 16, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@martijnvg
Copy link
Member

This will supersede #139611

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (assuming PR CI passes)

@jordan-powers jordan-powers enabled auto-merge (squash) December 16, 2025 19:42
Comment on lines +783 to +784
&& iv.onOrAfter(IndexVersions.SKIPPERS_ENABLED_BY_DEFAULT)
&& iv.before(IndexVersions.SKIPPER_DEFAULTS_ONLY_ON_TSDB)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit] you can use between()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point but it's probably not worth delaying the release by fixing this and re-running CI. But we can address this in a follow-up when we merge the fix back to main.

Copy link
Contributor

@Kubik42 Kubik42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jordan-powers jordan-powers merged commit 3669e63 into elastic:patch/serverless-fix Dec 16, 2025
36 checks passed
jordan-powers added a commit that referenced this pull request Dec 18, 2025
jordan-powers added a commit to jordan-powers/elasticsearch that referenced this pull request Dec 18, 2025
elasticsearchmachine pushed a commit that referenced this pull request Dec 18, 2025
szybia added a commit to szybia/elasticsearch that referenced this pull request Jan 7, 2026
* upstream/main:
  Add hook for blocking termination (elastic#133555)
  Delegate to ES93ScalarQuantizedVectorsFormat rather than copying behaviour (elastic#139834)
  Refactor compound block types (elastic#140219)
  Flush the rate buffer when the slice index changes (elastic#138856)
  Log linked project connection errors at debug during shutdown (elastic#140239)
  Periodic FIPS 140-3 buildkite pipelines (elastic#139909)
  ES|QL - Remove TERM function (elastic#139953)
  Fix name of started time field in shutdown status (elastic#139910)
  Drop `project_routing` from query params (elastic#140272)
  Fix flaky test: AllocationDecidersTests (elastic#140271)
  Add List Reindex API (elastic#140184)
  Expose _tier metadata attribute in ESQL (elastic#139894)
  Tweak TSDBRestEsqlIT#testTimeSeriesQuerying(...) (elastic#140210)
  Fix an OOM error when creating to many chained synonym graph token filter. (elastic#140026)
  Suppress Azure SDK error logs (elastic#139730)
  Rewritten integer sorts need to use SortedNumericSortField (elastic#139538) (elastic#139700)
  Adjust index versions for skippers for time series (elastic#139670)
  Fix host.name skippers index version range (elastic#139636)
  Remove BWC shim for a broken commit
  Fix index.mapping.use_doc_values_skipper defaults in serverless (elastic#139532)
sidosera pushed a commit to sidosera/elasticsearch that referenced this pull request Jan 7, 2026
* Revert "Remove BWC shim for a broken commit"

This reverts commit 5cc9804.

* Fix indexversion range check on hostname skippers
@jordan-powers jordan-powers deleted the fix-skippers-serverless-patch branch January 15, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>non-issue serverless-linked Added by automation, don't add manually :StorageEngine/Mapping The storage related side of mappings Team:StorageEngine v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments