Skip to content

Fix name of started time field in shutdown status#139910

Merged
rjernst merged 3 commits intoelastic:mainfrom
rjernst:shutdown/started_field_rename
Jan 7, 2026
Merged

Fix name of started time field in shutdown status#139910
rjernst merged 3 commits intoelastic:mainfrom
rjernst:shutdown/started_field_rename

Conversation

@rjernst
Copy link
Member

@rjernst rjernst commented Dec 22, 2025

This commit adjusts the field name indicated the time a shutdown started to be consistent with other millis based times, using the _millis suffix with an underscore. Note that this API is private so making rest changes without bwc is ok.

closes #139543

This commit adjusts the field name indicated the time a shutdown started
to be consistent with other millis based times, using the `_millis`
suffix with an underscore. Note that this API is private so making
rest changes without bwc is ok.

closes elastic#139543
@rjernst rjernst added >refactoring :Core/Infra/Node Lifecycle Node startup, bootstrapping, and shutdown auto-backport Automatically create backport pull requests when merged branch:9.2 branch:9.1 branch:8.19 branch:9.3 labels Dec 22, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@rjernst
Copy link
Member Author

rjernst commented Dec 22, 2025

making rest changes without bwc is ok

Unfortunately this isn't quite correct because the shutdown is serialized to cluster state. We'll need some limited bwc.

Copy link
Contributor

@mamazzol mamazzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjernst rjernst merged commit 0e5ec0a into elastic:main Jan 7, 2026
35 checks passed
@rjernst rjernst deleted the shutdown/started_field_rename branch January 7, 2026 16:01
rjernst added a commit to rjernst/elasticsearch that referenced this pull request Jan 7, 2026
This commit adjusts the field name indicated the time a shutdown started
to be consistent with other millis based times, using the `_millis`
suffix with an underscore. Note that this API is private so making
rest changes without bwc is ok.

closes elastic#139543
rjernst added a commit to rjernst/elasticsearch that referenced this pull request Jan 7, 2026
This commit adjusts the field name indicated the time a shutdown started
to be consistent with other millis based times, using the `_millis`
suffix with an underscore. Note that this API is private so making
rest changes without bwc is ok.

closes elastic#139543
rjernst added a commit to rjernst/elasticsearch that referenced this pull request Jan 7, 2026
This commit adjusts the field name indicated the time a shutdown started
to be consistent with other millis based times, using the `_millis`
suffix with an underscore. Note that this API is private so making
rest changes without bwc is ok.

closes elastic#139543
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
9.1
9.2
8.19
9.3

rjernst added a commit to rjernst/elasticsearch that referenced this pull request Jan 7, 2026
This commit adjusts the field name indicated the time a shutdown started
to be consistent with other millis based times, using the `_millis`
suffix with an underscore. Note that this API is private so making
rest changes without bwc is ok.

closes elastic#139543
elasticsearchmachine pushed a commit that referenced this pull request Jan 7, 2026
This commit adjusts the field name indicated the time a shutdown started
to be consistent with other millis based times, using the `_millis`
suffix with an underscore. Note that this API is private so making
rest changes without bwc is ok.

closes #139543
elasticsearchmachine pushed a commit that referenced this pull request Jan 7, 2026
This commit adjusts the field name indicated the time a shutdown started
to be consistent with other millis based times, using the `_millis`
suffix with an underscore. Note that this API is private so making
rest changes without bwc is ok.

closes #139543
szybia added a commit to szybia/elasticsearch that referenced this pull request Jan 7, 2026
* upstream/main:
  Add hook for blocking termination (elastic#133555)
  Delegate to ES93ScalarQuantizedVectorsFormat rather than copying behaviour (elastic#139834)
  Refactor compound block types (elastic#140219)
  Flush the rate buffer when the slice index changes (elastic#138856)
  Log linked project connection errors at debug during shutdown (elastic#140239)
  Periodic FIPS 140-3 buildkite pipelines (elastic#139909)
  ES|QL - Remove TERM function (elastic#139953)
  Fix name of started time field in shutdown status (elastic#139910)
  Drop `project_routing` from query params (elastic#140272)
  Fix flaky test: AllocationDecidersTests (elastic#140271)
  Add List Reindex API (elastic#140184)
  Expose _tier metadata attribute in ESQL (elastic#139894)
  Tweak TSDBRestEsqlIT#testTimeSeriesQuerying(...) (elastic#140210)
  Fix an OOM error when creating to many chained synonym graph token filter. (elastic#140026)
  Suppress Azure SDK error logs (elastic#139730)
  Rewritten integer sorts need to use SortedNumericSortField (elastic#139538) (elastic#139700)
  Adjust index versions for skippers for time series (elastic#139670)
  Fix host.name skippers index version range (elastic#139636)
  Remove BWC shim for a broken commit
  Fix index.mapping.use_doc_values_skipper defaults in serverless (elastic#139532)
sidosera pushed a commit to sidosera/elasticsearch that referenced this pull request Jan 7, 2026
This commit adjusts the field name indicated the time a shutdown started
to be consistent with other millis based times, using the `_millis`
suffix with an underscore. Note that this API is private so making
rest changes without bwc is ok.

closes elastic#139543
ywangd added a commit to ywangd/elasticsearch that referenced this pull request Jan 9, 2026
elasticsearchmachine pushed a commit that referenced this pull request Jan 9, 2026
This commit adjusts the field name indicated the time a shutdown started
to be consistent with other millis based times, using the `_millis`
suffix with an underscore. Note that this API is private so making
rest changes without bwc is ok.

closes #139543

Co-authored-by: Yang Wang <yang.wang@elastic.co>
rjernst added a commit to rjernst/elasticsearch that referenced this pull request Jan 15, 2026
Backports for elastic#139910
were released in different releases, causing some upgrade paths to be
broken. This commit adds a note about a failure that can occur between
9.1.10 and 9.2.4.
rjernst added a commit that referenced this pull request Jan 15, 2026
Backports for #139910
were released in different releases, causing some upgrade paths to be
broken. This commit adds a note about a failure that can occur between
9.1.10 and 9.2.4.
elasticsearchmachine pushed a commit that referenced this pull request Jan 16, 2026
…140287)

* Fix name of started time field in shutdown status (#139910)

This commit adjusts the field name indicated the time a shutdown started
to be consistent with other millis based times, using the `_millis`
suffix with an underscore. Note that this API is private so making
rest changes without bwc is ok.

closes #139543

* fix docs

---------

Co-authored-by: Yang Wang <yang.wang@elastic.co>
Co-authored-by: Moritz Mack <mmack@apache.org>
spinscale pushed a commit to spinscale/elasticsearch that referenced this pull request Jan 21, 2026
Backports for elastic#139910
were released in different releases, causing some upgrade paths to be
broken. This commit adds a note about a failure that can occur between
9.1.10 and 9.2.4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-backport Automatically create backport pull requests when merged :Core/Infra/Node Lifecycle Node startup, bootstrapping, and shutdown >refactoring Team:Core/Infra Meta label for core/infra team v8.19.10 v9.1.10 v9.2.4 v9.3.1 v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typo in shutdown API response shutdown_startedmillis

3 participants

Comments