Fix an OOM error when creating to many chained synonym graph token filter. by afoucret · Pull Request #140026 · elastic/elasticsearch

afoucret · 2025-12-29T16:07:56Z

b36152d: Add YAML REST tests that describe the current behavior when chaining synonym graph token filters (check no functional regression in the patch)
589c712: Add unit tests for chained analyzer creation at scale (100 synonyms set each containing 10_000 rules).
32d60e5 Fix that prevent to apply preceding synonym filter when building the synonym token filter

markjhoy · 2025-12-29T22:50:14Z

...s/analysis-common/src/test/java/org/elasticsearch/analysis/common/SynonymsAnalysisTests.java

+            ts.reset();
+            assertTrue("Should produce at least one token", ts.incrementToken());
+            ts.close();
+        }


Just to help the test GC along, you may want to place:

indexAnalyzers = null;

at the end of the test. (context: playing with the test, I had it loop through the entire test 20 times, and it OOM'd for me... adding this inside the loop, it passed). Not saying an OOM will happen during a CI test run with just the one time through in the test, but it can't hurt just in case.

markjhoy

Overall, looks good, and the logic for the overridden method makes sense.

Left one comment in the unit tests, but overall, I think this will work.

ChrisHegarty

LGTM

elasticsearchmachine · 2025-12-30T10:33:16Z

Pinging @elastic/es-search-relevance (Team:Search Relevance)

afoucret · 2025-12-31T09:59:17Z

💚 All backports created successfully

Status	Branch	Result
✅	main

Questions ?

Please refer to the Backport tool documentation

…lter. (elastic#140026) * Create YAML REST test for chained synonym filters. * Adding some unit tests for chained synonyms graph filters creation. * Ensure previous synonyms set from the chain aren't applied again. (cherry picked from commit e6bd70d)

…lter. (#140026) (#140096)

* upstream/main: Add hook for blocking termination (elastic#133555) Delegate to ES93ScalarQuantizedVectorsFormat rather than copying behaviour (elastic#139834) Refactor compound block types (elastic#140219) Flush the rate buffer when the slice index changes (elastic#138856) Log linked project connection errors at debug during shutdown (elastic#140239) Periodic FIPS 140-3 buildkite pipelines (elastic#139909) ES|QL - Remove TERM function (elastic#139953) Fix name of started time field in shutdown status (elastic#139910) Drop `project_routing` from query params (elastic#140272) Fix flaky test: AllocationDecidersTests (elastic#140271) Add List Reindex API (elastic#140184) Expose _tier metadata attribute in ESQL (elastic#139894) Tweak TSDBRestEsqlIT#testTimeSeriesQuerying(...) (elastic#140210) Fix an OOM error when creating to many chained synonym graph token filter. (elastic#140026) Suppress Azure SDK error logs (elastic#139730) Rewritten integer sorts need to use SortedNumericSortField (elastic#139538) (elastic#139700) Adjust index versions for skippers for time series (elastic#139670) Fix host.name skippers index version range (elastic#139636) Remove BWC shim for a broken commit Fix index.mapping.use_doc_values_skipper defaults in serverless (elastic#139532)

…lter. (elastic#140026) * Create YAML REST test for chained synonym filters. * Adding some unit tests for chained synonyms graph filters creation. * Ensure previous synonyms set from the chain aren't applied again. (cherry picked from commit e6bd70d)

Mikep86 · 2026-02-05T20:33:54Z

💚 All backports created successfully

Status	Branch	Result
✅	9.3
✅	9.2
✅	8.19

Questions ?

Please refer to the Backport tool documentation

…lter. (elastic#140026) * Create YAML REST test for chained synonym filters. * Adding some unit tests for chained synonyms graph filters creation. * Ensure previous synonyms set from the chain aren't applied again. (cherry picked from commit e6bd70d)

…lter. (#140026) (#141966) * Create YAML REST test for chained synonym filters. * Adding some unit tests for chained synonyms graph filters creation. * Ensure previous synonyms set from the chain aren't applied again. (cherry picked from commit e6bd70d) Co-authored-by: Aurélien FOUCRET <aurelien.foucret@gmail.com>

…lter. (#140026) (#141965) * Create YAML REST test for chained synonym filters. * Adding some unit tests for chained synonyms graph filters creation. * Ensure previous synonyms set from the chain aren't applied again. (cherry picked from commit e6bd70d) Co-authored-by: Aurélien FOUCRET <aurelien.foucret@gmail.com>

…lter. (#140026) (#141964) * Create YAML REST test for chained synonym filters. * Adding some unit tests for chained synonyms graph filters creation. * Ensure previous synonyms set from the chain aren't applied again. (cherry picked from commit e6bd70d) Co-authored-by: Aurélien FOUCRET <aurelien.foucret@gmail.com>

elasticsearchmachine added the v9.4.0 label Dec 29, 2025

afoucret changed the base branch from main to patch/serverless-fix December 29, 2025 16:13

Create YAML REST test for chained synonym filters.

b36152d

afoucret force-pushed the fix-chained-synonyms-oom-reload branch from 2a4b17f to b36152d Compare December 29, 2025 16:21

afoucret added 2 commits December 29, 2025 23:18

Adding some unit tests for chained synonyms graph filters creation.

589c712

Ensure previous synonyms set from the chain aren't applied again.

32d60e5

afoucret force-pushed the fix-chained-synonyms-oom-reload branch from cd3ee68 to 32d60e5 Compare December 29, 2025 22:19

markjhoy reviewed Dec 29, 2025

View reviewed changes

markjhoy approved these changes Dec 29, 2025

View reviewed changes

ChrisHegarty approved these changes Dec 30, 2025

View reviewed changes

afoucret marked this pull request as ready for review December 30, 2025 09:45

elasticsearchmachine added the needs:triage Requires assignment of a team area label label Dec 30, 2025

afoucret added >bug :Search Relevance/Search Catch all for Search Relevance and removed needs:triage Requires assignment of a team area label labels Dec 30, 2025

elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Dec 30, 2025

afoucret merged commit e6bd70d into elastic:patch/serverless-fix Dec 30, 2025
35 checks passed

afoucret mentioned this pull request Dec 31, 2025

[main] Fix an OOM error when creating to many chained synonym graph token filter. (#140026) #140096

Merged

afoucret added a commit that referenced this pull request Jan 5, 2026

Fix an OOM error when creating to many chained synonym graph token fi…

aa56256

…lter. (#140026) (#140096)

mayya-sharipova mentioned this pull request Jan 7, 2026

Synonyms work #140268

Open

10 tasks

Mikep86 mentioned this pull request Feb 5, 2026

[9.3] Fix an OOM error when creating to many chained synonym graph token filter. (#140026) #141964

Merged

This was referenced Feb 5, 2026

[9.2] Fix an OOM error when creating to many chained synonym graph token filter. (#140026) #141965

Merged

[8.19] Fix an OOM error when creating to many chained synonym graph token filter. (#140026) #141966

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

Fix an OOM error when creating to many chained synonym graph token filter.#140026

Fix an OOM error when creating to many chained synonym graph token filter.#140026
afoucret merged 3 commits intoelastic:patch/serverless-fixfrom
afoucret:fix-chained-synonyms-oom-reload

afoucret commented Dec 29, 2025 •

edited

Loading

Uh oh!

markjhoy Dec 29, 2025 •

edited

Loading

Uh oh!

markjhoy left a comment

Uh oh!

ChrisHegarty left a comment

Uh oh!

elasticsearchmachine commented Dec 30, 2025

Uh oh!

Uh oh!

afoucret commented Dec 31, 2025

Uh oh!

Mikep86 commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Comments

Conversation

afoucret commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

markjhoy Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

markjhoy left a comment

Choose a reason for hiding this comment

Uh oh!

ChrisHegarty left a comment

Choose a reason for hiding this comment

Uh oh!

elasticsearchmachine commented Dec 30, 2025

Uh oh!

Uh oh!

afoucret commented Dec 31, 2025

💚 All backports created successfully

Questions ?

Uh oh!

Mikep86 commented Feb 5, 2026

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

afoucret commented Dec 29, 2025 •

edited

Loading

markjhoy Dec 29, 2025 •

edited

Loading