fix(axis): correct tick alignment in ordinal scale with numeric values#1609
Merged
markov00 merged 2 commits intoelastic:masterfrom Mar 1, 2022
Merged
Conversation
markov00
added
bug
nickofthyme
approved these changes
Feb 28, 2022
packages/charts/src/chart_types/xy_chart/state/selectors/visible_ticks.ts
Show resolved
Hide resolved
nickofthyme
pushed a commit
that referenced
this pull request
Mar 1, 2022
#1609) The tick line and label correctly renders now when using an ordinal scale with numeric values on the x axis.
nickofthyme
pushed a commit
that referenced
this pull request
Mar 1, 2022
# [44.0.0](v43.1.1...v44.0.0) (2022-03-01) ### Bug Fixes * **axis:** correct tick alignment in ordinal scale with numeric values ([#1609](#1609)) ([915349d](915349d)) * **legend:** width with duplicate nested pie slice labels ([#1585](#1585)) ([1073231](1073231)) * **partition:** consider legend extras when computing the legend size ([#1611](#1611)) ([2078f3d](2078f3d)) * **xy:** dataIndex keeps original data order on small multiples ([#1597](#1597)) ([9e2566c](9e2566c)) ### Features * **api:** expose Predicate enum ([#1574](#1574)) ([1f73eec](1f73eec)) * **heatmap:** allow rotation of x axis labels ([#1514](#1514)) ([b655156](b655156)) ### BREAKING CHANGES * **heatmap:** `width`, `align`, and `baseline` style properties are removed from the `xAxisLabels` and `yAxisLabels` style of the Heatmap theme. Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The tick line and label correctly renders now when using an ordinal scale with numeric values on the x axis.
Details
The changes were applied in #1446 to remove tick labels that were outside the domain in a multi-layer time axis.
The problem was caused by the fact that the tick position was limited to the min value between the
domain[0]and the value itself. Thedomain[0], in a continuous scale is the minimum, but when using an ordinal scale, thedomain[0]is the first value of the domain and, in a non ordered or just reversed, numerical domain, it can be different than the actual min. This caused the wrong positioning of the labels.In the VRT test, the change on the data order is desired to check for regressions.
If you want to double-check locally just replace the changed line to the original version:
Issues
fix #1608
Checklist
:xy,:partition):interactions,:axis)closes #123,fixes #123)