Skip to content

fix(xy): multilayer time axis tick/grid only when tick is inside domain#1446

Merged
monfera merged 2 commits intoelastic:masterfrom
monfera:gridline-only-in-domain
Oct 28, 2021
Merged

fix(xy): multilayer time axis tick/grid only when tick is inside domain#1446
monfera merged 2 commits intoelastic:masterfrom
monfera:gridline-only-in-domain

Conversation

@monfera
Copy link
Contributor

@monfera monfera commented Oct 28, 2021

Summary

  • no grid and tick lines for the leftmost, still labeled ticks if they're outside the shown domain, similar to the timeslip prototype
  • instead of showing the start of the domain, the tick label for not shown ticks shows the value for the tick, rather than for the start of the domain

Details

Issues

Partial fulfilment of #1442

Checklist

  • The proper chart type label has been added (e.g. :xy, :partition)
  • The proper feature labels have been added (e.g. :interactions, :axis)
  • The :theme label has been added and the @elastic/eui-design team has been pinged when there are Theme API changes
  • All related issues have been linked (i.e. closes #123, fixes #123)
  • New public API exports have been added to packages/charts/src/index.ts
  • Unit tests have been added or updated to match the most common scenarios
  • The proper documentation and/or storybook story has been added or updated
  • The code has been checked for cross-browser compatibility (Chrome, Firefox, Safari, Edge)
  • Visual changes have been tested with all available themes including dark, light, eui-dark & eui-light

@monfera monfera force-pushed the gridline-only-in-domain branch from af7c52e to 9581c99 Compare October 28, 2021 12:58
@monfera monfera added :axis Axis related issue :xy Bar/Line/Area chart related bug Something isn't working labels Oct 28, 2021
@monfera monfera requested a review from markov00 October 28, 2021 13:01
@monfera monfera mentioned this pull request Oct 28, 2021
18 tasks
Copy link
Collaborator

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works perfectly!
This definitely improves the output of the timeslip

@monfera monfera merged commit 1d06a1e into elastic:master Oct 28, 2021
@monfera
Copy link
Contributor Author

monfera commented Oct 28, 2021

Thanks @markov00 for spotting the gap 👍

nickofthyme pushed a commit that referenced this pull request Oct 29, 2021
## [38.1.2](v38.1.1...v38.1.2) (2021-10-29)

### Bug Fixes

* **xy:** multilayer time axis tick/grid only when tick is inside domain ([#1446](#1446)) ([1d06a1e](1d06a1e))
* **xy:** show mouse cursors on charts with opaque background ([#1447](#1447)) ([e0f1543](e0f1543))
@nickofthyme
Copy link
Collaborator

🎉 This PR is included in version 38.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:axis Axis related issue bug Something isn't working released Issue released publicly :xy Bar/Line/Area chart related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants