fix(xy): dataIndex keep original data order on small multiples#1597
Merged
markov00 merged 5 commits intoelastic:masterfrom Feb 17, 2022
Merged
fix(xy): dataIndex keep original data order on small multiples#1597markov00 merged 5 commits intoelastic:masterfrom
markov00 merged 5 commits intoelastic:masterfrom
Conversation
markov00
changed the title
markov00
added
:data
markov00
changed the title
monfera
approved these changes
Feb 17, 2022
nickofthyme
pushed a commit
that referenced
this pull request
Mar 1, 2022
# [44.0.0](v43.1.1...v44.0.0) (2022-03-01) ### Bug Fixes * **axis:** correct tick alignment in ordinal scale with numeric values ([#1609](#1609)) ([915349d](915349d)) * **legend:** width with duplicate nested pie slice labels ([#1585](#1585)) ([1073231](1073231)) * **partition:** consider legend extras when computing the legend size ([#1611](#1611)) ([2078f3d](2078f3d)) * **xy:** dataIndex keeps original data order on small multiples ([#1597](#1597)) ([9e2566c](9e2566c)) ### Features * **api:** expose Predicate enum ([#1574](#1574)) ([1f73eec](1f73eec)) * **heatmap:** allow rotation of x axis labels ([#1514](#1514)) ([b655156](b655156)) ### BREAKING CHANGES * **heatmap:** `width`, `align`, and `baseline` style properties are removed from the `xAxisLabels` and `yAxisLabels` style of the Heatmap theme. Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
nickofthyme
pushed a commit
that referenced
this pull request
Mar 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
dataIndexpredicate, used to keep the original data array sorting doesn't wrongly fall back anymore into thenumAscsort predicate, but has its own sorting function that returns just the original sorting.Details
A storybook example was removed as it was not used in our current setup.
Issues
fix #1593
Checklist
:xy,:partition):interactions,:axis)closes #123,fixes #123)