feat(heatmap): allow rotation of x axis labels#1514
Merged
markov00 merged 41 commits intoelastic:masterfrom Feb 23, 2022
Merged
feat(heatmap): allow rotation of x axis labels#1514markov00 merged 41 commits intoelastic:masterfrom
markov00 merged 41 commits intoelastic:masterfrom
Conversation
markov00
reviewed
Dec 9, 2021
packages/charts/src/chart_types/heatmap/layout/viewmodel/viewmodel.ts
Outdated
Show resolved
Hide resolved
packages/charts/src/chart_types/heatmap/renderer/canvas/canvas_renderers.ts
Show resolved
Hide resolved
Contributor
Author
|
jenkins test this |
monfera
reviewed
Feb 16, 2022
monfera
reviewed
Feb 16, 2022
monfera
suggested changes
Feb 16, 2022
Contributor
monfera
left a comment
There was a problem hiding this comment.
The overlap (and secondarily, rotating time tick labels in the example) look unintended, conveying less than ideal practice to users
monfera
approved these changes
Feb 23, 2022
Contributor
monfera
left a comment
There was a problem hiding this comment.
Good for merging once all tests pass
nickofthyme
pushed a commit
that referenced
this pull request
Mar 1, 2022
The `rotation` configuration is available on the `theme.heatmap.xAxisLabel` theme style to rotate the labels of the X-axis from 0 to 90 degrees. The rotation will shrink the chart vertically( and occasionally also horizontally) depending on the length of the labels. Few changes to the x-axis labels are also landed in this PR: - categorical labels overflowing the chart boundaries will play a role in shrinking the chart size. - the X-axis now shows small ticks, center-aligned for categorical scale and left-aligned for time - the time axis ticks are aligned to the right of the ticks - time axis labels instead, will not shrink the chart anymore. The number of labels will be reduced gradually to avoid overlaps and overflows. The right edge of the heatmap will always touch the right edge of the rendering area. BREAKING CHANGE: `width`, `align`, and `baseline` style properties are removed from the `xAxisLabels` and `yAxisLabels` style of the Heatmap theme. Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
nickofthyme
pushed a commit
that referenced
this pull request
Mar 1, 2022
# [44.0.0](v43.1.1...v44.0.0) (2022-03-01) ### Bug Fixes * **axis:** correct tick alignment in ordinal scale with numeric values ([#1609](#1609)) ([915349d](915349d)) * **legend:** width with duplicate nested pie slice labels ([#1585](#1585)) ([1073231](1073231)) * **partition:** consider legend extras when computing the legend size ([#1611](#1611)) ([2078f3d](2078f3d)) * **xy:** dataIndex keeps original data order on small multiples ([#1597](#1597)) ([9e2566c](9e2566c)) ### Features * **api:** expose Predicate enum ([#1574](#1574)) ([1f73eec](1f73eec)) * **heatmap:** allow rotation of x axis labels ([#1514](#1514)) ([b655156](b655156)) ### BREAKING CHANGES * **heatmap:** `width`, `align`, and `baseline` style properties are removed from the `xAxisLabels` and `yAxisLabels` style of the Heatmap theme. Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
rotationconfiguration is available on thetheme.heatmap.xAxisLabeltheme style to rotate the labels of the X axis from 0 to 90 degree.The rotation will shrink the chart vertically( and occasionally also horizontally) depending on the length of the labels.
Few changes to the x axis labels are also landed in this PR:
BREAKING CHANGES
width,alignandbaselinestyle properties are removed from thexAxisLabelsandyAxisLabelsstyle of the Heatmap theme.These properties were not used in the rendering.
Details
Compute the X axis space
The X axis space is computed as the following:
categoricalscreenspaceMarkerScaleCompressorto compute how much we need to shrink the grid width considering the label positions in the domain and their screen size. I also included the Y axis so that we can take also the maximum label width in the calculation.timemultiLayerTimeAxisbut in a future step we can include that.Future possible steps
Issues
Partially solves #1168 (missing the automatic trimming of horizontal labels)
Checklist
:xy,:partition):interactions,:axis)closes #123,fixes #123)packages/charts/src/index.ts