Skip to content

[Agent] fixed mage package for agent#17368

Merged
michalpristas merged 1 commit intoelastic:masterfrom
michalpristas:agent-fix-dmg
Apr 1, 2020
Merged

[Agent] fixed mage package for agent#17368
michalpristas merged 1 commit intoelastic:masterfrom
michalpristas:agent-fix-dmg

Conversation

@michalpristas
Copy link
Copy Markdown
Contributor

@michalpristas michalpristas commented Mar 31, 2020

What does this PR do?

mage package for dmg was failing for agent as hdiutils create failed to fit content of package into volume.
Specifying a larger initial size of a volume seems to fix the issue.

Why is it important?

makes mage package work

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas michalpristas requested a review from ruflin March 31, 2020 15:53
@michalpristas michalpristas self-assigned this Mar 31, 2020
@ph
Copy link
Copy Markdown
Contributor

ph commented Mar 31, 2020

It's that new behavior from macOS? Where the 500m values comes from and does this mean the dmg will be 500megs?

@michalpristas
Copy link
Copy Markdown
Contributor Author

michalpristas commented Mar 31, 2020

500 megs is my value, i wanted to provide a value which is gt the actual size of image with some additional buffer.
not sure if this is new behavior though

@ph
Copy link
Copy Markdown
Contributor

ph commented Mar 31, 2020 •
edited
Loading

Weird, did you have the failling locally? I've run mage package multiple times on Linux without any problems? Maybe its recent to catalina?

@ph ph added needs_backport PR is waiting to be backported to other branches. Team:Ingest Management labels Mar 31, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 31, 2020

Pinging @elastic/ingest-management (Team:Ingest Management)

ruflin
ruflin approved these changes Mar 31, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, tested this locally and works again.

@ph I assume the dmg is not built on Linux.

@michalpristas
Copy link
Copy Markdown
Contributor Author

michalpristas commented Mar 31, 2020

@ruflin i suspect the same as i run package mostly in VM as it's faster and more reliable than mac builds.
@ph yeah locally failed for me and nicolas every time i tried to build

@ph
Copy link
Copy Markdown
Contributor

ph commented Mar 31, 2020

Yeah, odd. thanks @michalpristas LGTM

@ph
Copy link
Copy Markdown
Contributor

ph commented Mar 31, 2020

Tested on my mac works.

@michalpristas michalpristas merged commit 1dff73f into elastic:master Apr 1, 2020
@ph ph mentioned this pull request Apr 7, 2020
Merged
5 tasks
@ph ph removed the needs_backport PR is waiting to be backported to other branches. label Apr 7, 2020
@ph
Copy link
Copy Markdown
Contributor

ph commented Apr 7, 2020

backported in #17574 to have a working build

@ph ph added the needs_backport PR is waiting to be backported to other branches. label Apr 7, 2020
ph added a commit that referenced this pull request Apr 7, 2020
@ph @michalpristas
Cherry-pick #16927 to 7.x: Fix issue when building Agent snapshot and…
284b202 
… enable building the agent. (#17574)

* Fix issue when building Agent snapshot and enable building the agent. (#16927)

An extension in the generated files ("SNAPSHOT") was preventing us to
correctly generate the agent artifact with the packaged
metricbeat/filebeat.

Fixes: #16908
(cherry picked from commit 62d3683)

* [Agent] Fix installers (#17077)

[Agent] Fix installers for snapshots (#17077)

* [Agent] fixed mage package for agent (#17368)

[Agent] fixed mage package for agent (#17368)

* [Agent] Make default config OS agnostic (#17016)

[Agent] Make default config OS agnostic (#17016)

* [Agent] Docker image for integration tests (#16898)

[Agent] Docker image for integration tests (#16898)

Co-authored-by: Michal Pristas <michal.pristas@gmail.com>
@ph ph removed the needs_backport PR is waiting to be backported to other branches. label Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ruflin ruflin ruflin approved these changes

+1 more reviewer

@ph ph ph approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@michalpristas michalpristas

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@michalpristas @ph @elasticmachine @ruflin