[Agent] Make default config OS agnostic#17016
Merged
michalpristas merged 7 commits intoelastic:masterfrom Mar 17, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/ingest-management (Project:fleet) |
ruflin
approved these changes
Mar 16, 2020
Contributor
ruflin
left a comment
ruflin
left a comment
There was a problem hiding this comment.
LGTM. We should continue to iterate on the naming / paths but this already improves it.
| sourceURI: "https://artifacts.elastic.co/downloads/beats/" | ||
| # path to the directory containing downloaded packages | ||
| target_directory: "/home/elastic/downloads" | ||
| target_directory: "${path.data}/beats" |
Contributor
There was a problem hiding this comment.
Perhaps still call it downloads and not beats as this will also download endpoint?
Contributor
Author
|
|
Contributor
Author
|
going to test packaging before merge |
Contributor
|
added need backport label. |
michalpristas
force-pushed
the
agent-default-home
branch
from
f9b8625 to
70de174
Compare
5 tasks
Contributor
|
backported in #17574 to have a working build |
ph
added a commit
that referenced
this pull request
Apr 7, 2020
… enable building the agent. (#17574) * Fix issue when building Agent snapshot and enable building the agent. (#16927) An extension in the generated files ("SNAPSHOT") was preventing us to correctly generate the agent artifact with the packaged metricbeat/filebeat. Fixes: #16908 (cherry picked from commit 62d3683) * [Agent] Fix installers (#17077) [Agent] Fix installers for snapshots (#17077) * [Agent] fixed mage package for agent (#17368) [Agent] fixed mage package for agent (#17368) * [Agent] Make default config OS agnostic (#17016) [Agent] Make default config OS agnostic (#17016) * [Agent] Docker image for integration tests (#16898) [Agent] Docker image for integration tests (#16898) Co-authored-by: Michal Pristas <michal.pristas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PR changes path of
installanddownloaddirectories in default config to be OS agnostic by usingpath.data.Why is it important?
It simplifies first run experience when running agent by removing the need to change configuration values which are configured to non existent paths.
Checklist
How to test this PR locally
You need to build and package agent to contain
data/beatssubdirectory containing filebeat and metricbeat archives (tar.gz on linux and darwin).Second step is just running agent and verifying that metricbeat was installed to
data/installand is successfully started