Skip to content

Fix issue when building Agent snapshot and enable building the agent.#16927

Merged
ph merged 1 commit intoelastic:masterfrom
ph:agent/fix-artifacts-agent
Mar 11, 2020
Merged

Fix issue when building Agent snapshot and enable building the agent.#16927
ph merged 1 commit intoelastic:masterfrom
ph:agent/fix-artifacts-agent

Conversation

@ph
Copy link
Copy Markdown
Contributor

@ph ph commented Mar 10, 2020

An extension in the generated files ("SNAPSHOT") was preventing us to
correctly generate the agent artifact with the packaged
metricbeat/filebeat.

Fixes: #16908

What does this PR do?

Why is it important?

To have agent artifacts from the nigthly build.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

An extension in the generated files ("SNAPSHOT") was preventing us to
correctly generate the agent artifact with the packaged
metricbeat/filebeat.

Fixes: #16908
@ph ph added needs_backport PR is waiting to be backported to other branches. Packaging Project:fleet labels Mar 10, 2020
@ph ph requested a review from michalpristas March 10, 2020 14:43
@ph ph self-assigned this Mar 10, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/ingest-management (Project:fleet)

@ph
Copy link
Copy Markdown
Contributor Author

ph commented Mar 10, 2020

jenkins package

Copy link
Copy Markdown
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ph
Copy link
Copy Markdown
Contributor Author

ph commented Mar 10, 2020

The failure for x-pack/libbeat doesn't seem to be related to this PR, Actually looking at the output this look like an issue with the wrapper itself.

@ph ph merged commit 62d3683 into elastic:master Mar 11, 2020
@ph ph added v7.8.0 and removed needs_backport PR is waiting to be backported to other branches. labels Apr 7, 2020
ph added a commit that referenced this pull request Apr 7, 2020
… enable building the agent. (#17574)

* Fix issue when building Agent snapshot and enable building the agent. (#16927)

An extension in the generated files ("SNAPSHOT") was preventing us to
correctly generate the agent artifact with the packaged
metricbeat/filebeat.

Fixes: #16908
(cherry picked from commit 62d3683)

* [Agent] Fix installers (#17077)

[Agent] Fix installers for snapshots (#17077)

* [Agent] fixed mage package for agent (#17368)

[Agent] fixed mage package for agent (#17368)

* [Agent] Make default config OS agnostic (#17016)

[Agent] Make default config OS agnostic (#17016)

* [Agent] Docker image for integration tests (#16898)

[Agent] Docker image for integration tests (#16898)

Co-authored-by: Michal Pristas <michal.pristas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Agent] Make package fails when x-pack/agent is added to the BEATS'

3 participants