[Agent] Fix installers#17077
Merged
michalpristas merged 13 commits intoelastic:masterfrom Mar 24, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/ingest-management (Project:fleet) |
michalpristas
commented
Mar 18, 2020
| return installCmd.Run() | ||
| } | ||
|
|
||
| func alignInstallPath(installPath, version string) string { |
Contributor
Author
There was a problem hiding this comment.
this i dont like i will rewrite this part
Contributor
Author
|
Jenkins test this |
ph
reviewed
Mar 19, 2020
Contributor
ph
left a comment
ph
left a comment
There was a problem hiding this comment.
LGTM, but I haven't tested the artifacts.
Contributor
|
failures doesn't seem related to this PR? |
ph
approved these changes
Mar 23, 2020
Contributor
ph
left a comment
ph
left a comment
There was a problem hiding this comment.
LGTM, testing with agent run.
5 tasks
Contributor
|
backported in #17574 to have a working build |
ph
added a commit
that referenced
this pull request
Apr 7, 2020
… enable building the agent. (#17574) * Fix issue when building Agent snapshot and enable building the agent. (#16927) An extension in the generated files ("SNAPSHOT") was preventing us to correctly generate the agent artifact with the packaged metricbeat/filebeat. Fixes: #16908 (cherry picked from commit 62d3683) * [Agent] Fix installers (#17077) [Agent] Fix installers for snapshots (#17077) * [Agent] fixed mage package for agent (#17368) [Agent] fixed mage package for agent (#17368) * [Agent] Make default config OS agnostic (#17016) [Agent] Make default config OS agnostic (#17016) * [Agent] Docker image for integration tests (#16898) [Agent] Docker image for integration tests (#16898) Co-authored-by: Michal Pristas <michal.pristas@gmail.com>
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
May 6, 2020
[Agent] Fix installers for snapshots (elastic#17077)
michalpristas
added a commit
to michalpristas/beats
that referenced
this pull request
May 6, 2020
[Agent] Fix installers for snapshots (elastic#17077)
michalpristas
added a commit
that referenced
this pull request
May 6, 2020
michalpristas
added a commit
that referenced
this pull request
May 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR changes installers in two ways
SNAPSHOT handling
for now turned on by default, if we want to enable it only for snapshot agent we need to modify build to set flag at build time and then enable snapshot installer afterwards
windows refactor
install step on windows was not working properly, while we were unzipping we were creating one additional directory layer, this is now removed.
Small config change
Default configs are not using 9300 endpoint for ES from now on
Why is it important?
To simplify use case when running from snapshot and entire windows flow
Checklist
How to test this PR locally
Scenario 1
run
SNAPSHOT=true mage packageto build snapshot packageunpack it somewhere locally and try if it runs with no changes to config
Scenario 2
Same as 1 but on windows, windows was broken even for non SNAPSHOT packages.