feat: support node v17

[trentm]

Node v17.0.0 was released today per https://nodejs.org/en/about/releases/

We should officially add support (modulo this is not an LTS release). Adding to "engines" avoids this npm warning:

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '[email protected]',
npm WARN EBADENGINE   required: { node: '^8.6.0 || 10 || 12 || 14 || 15 || 16' },
npm WARN EBADENGINE   current: { node: 'v17.0.0', npm: '8.1.0' }
npm WARN EBADENGINE }

We will also add node v17 to list of versions we test.

Checklist

• Add CHANGELOG.asciidoc entry
• Commit message follows commit guidelines

[apmmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2021-10-21T16:29:52.347+0000

• Duration: 25 min 23 sec

• Commit: db85abb

Test stats 🧪

Test	Results
Failed	0
Passed	22
Skipped	0
Total	22

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

• run benchmark tests : Run the benchmark test only.

[trentm]

Waiting on https://hub.docker.com/_/node "node:17" docker image for our Jenkins CI, which is waiting on docker-library/official-images#11138 to be fixed, which will then go through this process https://github.com/docker-library/faq#an-images-source-changed-in-git-now-what

[trentm]

• outgoing http.request instrumentation exacerbates node issue with ipv6 addresses #2382 is one surprise we hit in the test suite
• Another one is "localhost" favours IPv6 in node v17, used to favour IPv4 nodejs/node#40537 which breaks because a Hapi server default listen address is '0.0.0.0' (IPv4), but in node v17 making a client request to "localhost" favours IPv6, leading to ECONNREFUSED:

% node --unhandled-rejections=strict test/instrumentation/modules/hapi/basic-legacy-path.test.js
TAP version 13
# extract URL from request
ok 1 no error from startServer
node:events:368
      throw er; // Unhandled 'error' event
      ^

Error: connect ECONNREFUSED ::1:58759
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1161:16)
    at TCPConnectWrap.callbackTrampoline (node:internal/async_hooks:130:17)
Emitted 'error' event on ClientRequest instance at:
    at Socket.socketErrorListener (node:_http_client:447:9)
    at Socket.emit (node:events:390:28)
    at emitErrorNT (node:internal/streams/destroy:164:8)
    at emitErrorCloseNT (node:internal/streams/destroy:129:3)
    at processTicksAndRejections (node:internal/process/task_queues:83:21) {
  errno: -61,
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '::1',
  port: 58759
}

Node.js v17.0.0

[trentm]

I'll add a changelog entry tomorrow, after I merge another change and update this branch, to avoid the merge conflict.

[astorm]

Changes look like the usual bit shifting between versions. 👍 Thanks for being on top of the Node.js release train. 🚋