tests: fix TAV test breakage with node 17 (hapi <=16, fastify <0.36.0) #2387

trentm · 2021-10-25T00:04:41Z

This was broken in #2380. Versions of hapi <=16 did not support the
'host' option to new Server, but instead to server.connection.

This was broken in #2380. Versions of hapi <=16 did not support the 'host' option to `new Server`, but instead to `server.connection`.

apmmachine · 2021-10-25T00:25:58Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2021-10-25T20:19:21.109+0000
Duration: 20 min 44 sec
Commit: 5e06aae

Test stats 🧪

Test	Results
Failed	0
Passed	22
Skipped	0
Total	22

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules
run benchmark tests : Run the benchmark test only.

trentm · 2021-10-25T02:37:54Z

^^^ I think TAV tests should have passed there in https://apm-ci.elastic.co/blue/organizations/jenkins/apm-agent-nodejs%2Fapm-agent-nodejs-mbp/detail/PR-2387/2/pipeline/
The only failure there is "Node.js-17-fastify" which failed with some npm error (transient?):

[2021-10-25T01:23:29.680Z] node_tests_1  | -- installing ["[email protected]"]
[2021-10-25T01:23:29.681Z] node_tests_1  | -- error installing ["[email protected]"] (npm WARN deprecated [email protected]: fixed critical security vulnerability
[2021-10-25T01:23:29.681Z] node_tests_1  | npm ERR! code ERR_INVALID_ARG_TYPE
[2021-10-25T01:23:29.681Z] node_tests_1  | npm ERR! The "from" argument must be of type string. Received undefined
[2021-10-25T01:23:29.681Z] node_tests_1  | 
[2021-10-25T01:23:29.681Z] node_tests_1  | npm ERR! A complete log of this run can be found in:
[2021-10-25T01:23:29.681Z] node_tests_1  | npm ERR!     /tmp/.npm/_logs/2021-10-25T01_23_28_905Z-debug.log
[2021-10-25T01:23:29.681Z] node_tests_1  | ) - retrying (2/10)...
[2021-10-25T01:23:32.966Z] node_tests_1  | -- installing ["[email protected]"]
[2021-10-25T01:23:32.966Z] node_tests_1  | -- error installing ["[email protected]"] (npm ERR! code ENOTEMPTY
[2021-10-25T01:23:32.966Z] node_tests_1  | npm ERR! syscall rename
[2021-10-25T01:23:32.966Z] node_tests_1  | npm ERR! path /app/node_modules/fastify
[2021-10-25T01:23:32.966Z] node_tests_1  | npm ERR! dest /app/node_modules/.fastify-ojXizKCz
[2021-10-25T01:23:32.966Z] node_tests_1  | npm ERR! errno -39
[2021-10-25T01:23:32.966Z] node_tests_1  | npm ERR! ENOTEMPTY: directory not empty, rename '/app/node_modules/fastify' -> '/app/node_modules/.fastify-ojXizKCz'
[2021-10-25T01:23:32.966Z] node_tests_1  | 
[2021-10-25T01:23:32.966Z] node_tests_1  | npm ERR! A complete log of this run can be found in:
[2021-10-25T01:23:32.966Z] node_tests_1  | npm ERR!     /tmp/.npm/_logs/2021-10-25T01_23_32_788Z-debug.log
[2021-10-25T01:23:32.966Z] node_tests_1  | ) - retrying (3/10)...

trentm · 2021-10-25T17:06:37Z

That fastify install error with node 17 reproduced, and can be reproduced locally:

% node --version
v17.0.0

% npm --version
8.1.0

Installing [email protected] works:

% npm install [email protected]
npm WARN deprecated [email protected]: This version contains severe security issues and defects and should not be used! Please upgrade to the latest version of @hapi/hapi or consider a commercial license (https://github.com/hapijs/hapi/issues/4114)
npm WARN deprecated [email protected]: fixed critical security vulnerability

added 120 packages, removed 29 packages, changed 12 packages, and audited 1609 packages in 6s

106 packages are looking for funding
  run `npm fund` for details

38 vulnerabilities (1 low, 12 moderate, 22 high, 3 critical)

To address issues that do not require attention, run:
  npm audit fix

To address all issues possible (including breaking changes), run:
  npm audit fix --force

Some issues need review, and may require choosing
a different dependency.

Run `npm audit` for details.

But installing the next earlier version fails:

% npm install [email protected]
npm WARN deprecated [email protected]: fixed critical security vulnerability
npm ERR! code ERR_INVALID_ARG_TYPE
npm ERR! The "from" argument must be of type string. Received undefined

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/trentm/.npm/_logs/2021-10-25T16_55_15_155Z-debug.log

And after that, things are screwed up with this npm install:

% npm install [email protected]
npm ERR! code ENOTEMPTY
npm ERR! syscall rename
npm ERR! path /Users/trentm/el/apm-agent-nodejs2/node_modules/fastify
npm ERR! dest /Users/trentm/el/apm-agent-nodejs2/node_modules/.fastify-KpO0ALDf
npm ERR! errno -66
npm ERR! ENOTEMPTY: directory not empty, rename '/Users/trentm/el/apm-agent-nodejs2/node_modules/fastify' -> '/Users/trentm/el/apm-agent-nodejs2/node_modules/.fastify-KpO0ALDf'

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/trentm/.npm/_logs/2021-10-25T16_56_14_674Z-debug.log

% npm install fastify
npm ERR! code ENOTEMPTY
npm ERR! syscall rename
npm ERR! path /Users/trentm/el/apm-agent-nodejs2/node_modules/fastify
npm ERR! dest /Users/trentm/el/apm-agent-nodejs2/node_modules/.fastify-KpO0ALDf
npm ERR! errno -66
npm ERR! ENOTEMPTY: directory not empty, rename '/Users/trentm/el/apm-agent-nodejs2/node_modules/fastify' -> '/Users/trentm/el/apm-agent-nodejs2/node_modules/.fastify-KpO0ALDf'

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/trentm/.npm/_logs/2021-10-25T16_58_08_359Z-debug.log

and it takes manual intervention to get it working again:

% rm -rf /Users/trentm/el/apm-agent-nodejs2/node_modules/fastify

% rm -rf node_modules/.fastify-KpO0ALDf

% npm install fastify
npm WARN deprecated [email protected]: fixed critical security vulnerability

added 14 packages, changed 1 package, and audited 1609 packages in 2s
...

proposal

Let's drop support for fastify versions from 2017 at least:

$ npm info -j fastify
...
    "0.27.0": "2017-09-10T21:34:48.763Z",
    "0.28.0": "2017-09-21T07:08:32.229Z",
    "0.28.1": "2017-09-21T08:48:46.114Z",
    "0.28.2": "2017-09-21T10:28:43.486Z",
    "0.29.0": "2017-09-25T17:08:35.665Z",
    "0.29.1": "2017-10-01T09:45:01.836Z",
    "0.29.2": "2017-10-01T14:11:48.543Z",
    "0.30.0": "2017-10-12T20:41:06.994Z",
    "0.30.1": "2017-10-13T13:57:02.398Z",
    "0.30.2": "2017-10-15T09:48:07.403Z",
    "0.30.3": "2017-10-26T20:47:07.512Z",
    "0.31.0": "2017-10-31T11:39:49.779Z",
    "0.32.0": "2017-11-03T10:22:11.904Z",
    "0.33.0": "2017-11-04T09:52:22.864Z",
    "0.34.0": "2017-11-15T14:39:20.822Z",
    "0.35.0": "2017-11-17T11:40:03.536Z",
    "0.35.1": "2017-11-20T22:32:08.045Z",
    "0.35.2": "2017-11-24T08:50:23.886Z",
    "0.35.3": "2017-12-01T22:11:15.950Z",
    "0.35.4": "2017-12-05T13:29:28.890Z",
    "0.35.5": "2017-12-05T15:32:28.089Z",
    "0.35.6": "2017-12-14T15:41:25.982Z",
    "0.35.7": "2017-12-14T15:45:09.035Z",
    "0.36.0": "2017-12-18T10:29:27.360Z",
    "0.37.0": "2017-12-22T16:38:14.486Z",
    "0.38.0": "2018-01-08T10:33:49.228Z",
    "0.39.0": "2018-01-11T16:22:31.272Z",
    "0.39.1": "2018-01-11T16:28:08.704Z",
    "0.40.0": "2018-01-23T18:46:41.372Z",
    "0.41.0": "2018-01-29T11:09:38.189Z",
    "0.42.0": "2018-02-01T14:47:14.025Z",
    "0.43.0": "2018-02-02T22:02:39.496Z",
    "1.0.0-rc.1": "2018-02-05T21:14:27.625Z",
    "1.0.0-rc.2": "2018-02-16T18:01:53.862Z",
    "1.0.0-rc.3": "2018-03-01T14:09:52.198Z",
    "1.0.0": "2018-03-06T16:41:24.416Z",
...

The minimum change here would be to not test fastify versions before 0.36.0 with node 17. However, that seems overly cautious: adding complexity to .tav.yml for unnecessary use cases. No one should be running these old fastify versions.

Options:

Do the "mininum change".
Drop support for fastify versions before 0.38.0 (anything released in 2017).
Drop support for fastify versions before 1.0.0. There are currently 1.x and 2.x maint branches in fastify's git. See also https://github.com/fastify/fastify/blob/main/README.md#fastify-v1x-and-v2x. There are no maint branches for pre-1.0.0 releases.

trentm · 2021-10-25T17:47:28Z

There is also a failure attempting to test/use some older fastify 1.x versions with node 17:

...
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
node:events:368
      throw er; // Unhandled 'error' event
      ^

Error: connect ECONNREFUSED ::1:54452
    at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1161:16)
    at TCPConnectWrap.callbackTrampoline (node:internal/async_hooks:130:17)
Emitted 'error' event on ClientRequest instance at:
    at Socket.socketErrorListener (node:_http_client:447:9)
    at Socket.emit (node:events:390:28)
    at emitErrorNT (node:internal/streams/destroy:164:8)
    at emitErrorCloseNT (node:internal/streams/destroy:129:3)
    at processTicksAndRejections (node:internal/process/task_queues:83:21) {
  errno: -61,
  code: 'ECONNREFUSED',
  syscall: 'connect',
  address: '::1',
  port: 54452
}

Node.js v17.0.0
-- detected failing command, flushing stdout...
TAP version 13
# transaction name
{"log.level":"warn","@timestamp":"2021-10-25T17:29:45.286Z","log":{"logger":"elastic-apm-node"},"ecs":{"version":"1.6.0"},"message":"Elastic APM cannot automaticaly capture errors on this verison of Fastify. Upgrade to version 2.0.0 or later."}
ok 1 null

-- fatal: Test exited with code 1

However, fastify doesn't support 1.x with node 17: https://www.fastify.io/docs/latest/LTS/
So let's not bother testing 1.x with node 17. Further, let's only test with supported node versions in that LTS doc.
After update .tav.yml to do this, here is a node v17 passing TAV run for fastify:

% TAV=fastify npm run test:tav

> [email protected] test:tav
> tav --quiet

-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- required packages ["[email protected]"]
-- installing ["[email protected]"]
-- running test "node test/instrumentation/modules/fastify/fastify.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/async-await.test.js" with fastify
-- running test "node test/instrumentation/modules/fastify/set-framework.test.js" with fastify
-- ok

% node --version
v17.0.0

…stify.io/docs/latest/LTS/ says are supported for that major version

trentm · 2021-10-25T17:49:37Z

https://apm-ci.elastic.co/job/apm-agent-nodejs/job/apm-agent-nodejs-mbp/job/PR-2387/ build 5 is a TAV test run.

trentm · 2021-10-25T19:39:41Z

This should get a changelog entry as well, but I'm waiting for the ES client v8 PR to go in first to avoid a merge conflict.

tests: fix TAV test breakage with hapi <=16

8b86ff2

This was broken in #2380. Versions of hapi <=16 did not support the 'host' option to `new Server`, but instead to `server.connection`.

trentm self-assigned this Oct 25, 2021

github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Oct 25, 2021

trentm changed the title ~~tests: fix TAV test breakage with hapi <=16~~ tests: fix TAV test breakage with node 17 (hapi <=16, fastify <0.36.0) Oct 25, 2021

only test fastify releases with the node versions that https://www.fa…

e4fc310

…stify.io/docs/latest/LTS/ says are supported for that major version

trentm requested a review from astorm October 25, 2021 19:39

trentm mentioned this pull request Oct 25, 2021

feat: support @elastic/elasticsearch@8 #2385

Merged

5 tasks

trentm added 2 commits October 25, 2021 13:15

Merge branch 'master' into trentm/tav-hapi16-breakage

1f38a4f

changelog update about fastify support for pre 1.0.0

5e06aae

astorm approved these changes Oct 25, 2021

View reviewed changes

trentm merged commit 1693568 into master Oct 25, 2021

trentm deleted the trentm/tav-hapi16-breakage branch October 25, 2021 22:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests: fix TAV test breakage with node 17 (hapi <=16, fastify <0.36.0) #2387

tests: fix TAV test breakage with node 17 (hapi <=16, fastify <0.36.0) #2387

trentm commented Oct 25, 2021

apmmachine commented Oct 25, 2021 •

edited

Loading

Build stats

Test stats 🧪

trentm commented Oct 25, 2021

trentm commented Oct 25, 2021

trentm commented Oct 25, 2021

trentm commented Oct 25, 2021

trentm commented Oct 25, 2021

tests: fix TAV test breakage with node 17 (hapi <=16, fastify <0.36.0) #2387

tests: fix TAV test breakage with node 17 (hapi <=16, fastify <0.36.0) #2387

Conversation

trentm commented Oct 25, 2021

apmmachine commented Oct 25, 2021 • edited Loading

💚 Build Succeeded

Build stats

Test stats 🧪

🤖 GitHub comments

trentm commented Oct 25, 2021

trentm commented Oct 25, 2021

proposal

trentm commented Oct 25, 2021

trentm commented Oct 25, 2021

trentm commented Oct 25, 2021

apmmachine commented Oct 25, 2021 •

edited

Loading