tests: fix TAV test breakage with node 17 (hapi <=16, fastify <0.36.0) (

#2387)

This was broken in #2380. Versions of hapi <=16 did not support the
'host' option to `new Server`, but instead to `server.connection`.
Also really old versions of fastify (v0.35.7) cannot even be npm installed
with the npm included in node v17. This drops support for fastify <1.0.0
and updates the TAV test matrix to only test a given fastify version
with its supported versions of node per https://www.fastify.io/docs/latest/LTS/

.tav.yml

@@ -407,8 +407,28 @@ restify-new:
     - node test/instrumentation/modules/restify/basic.test.js
     - node test/instrumentation/modules/restify/set-framework.test.js
 
+# https://www.fastify.io/docs/latest/LTS/
+# - #1086 suggests [email protected] was a broken release, skip it.
+fastify-v1:
+  name: fastify
+  versions: '1.x'
+  node: '>=6 <12'
+  commands:
+    - node test/instrumentation/modules/fastify/fastify.test.js
+    - node test/instrumentation/modules/fastify/async-await.test.js
+    - node test/instrumentation/modules/fastify/set-framework.test.js
+fastify-v2:
+  name: fastify
+  versions: '>=2.0.0 <2.4.0 || >2.4.0 <3'
+  node: '>=6 <15'
+  commands:
+    - node test/instrumentation/modules/fastify/fastify.test.js
+    - node test/instrumentation/modules/fastify/async-await.test.js
+    - node test/instrumentation/modules/fastify/set-framework.test.js
 fastify:
-  versions: '>=0.27.0 <0.29.0 || >0.29.0 <2.4.0 || >2.4.0'
+  name: fastify
+  versions: '>=3.0.0'
+  node: '>=10'
   commands:
     - node test/instrumentation/modules/fastify/fastify.test.js
     - node test/instrumentation/modules/fastify/async-await.test.js

CHANGELOG.asciidoc

@@ -33,11 +33,17 @@ Notes:
 [float]
 ===== Breaking changes
 
+* Remove support for instrumenting versions of fastify earlier than 1.0.0.
+  This instrumentation might still work, but is no longer supported.
+  Fastify v1.0.0 was released in 2018. All current users should be using
+  fastify v2 or v3 at least. See https://www.fastify.io/docs/latest/LTS/
+  ({pull}2387[#2387])
+
 [float]
 ===== Features
 
-* Add initial support for version 8 of `@elastic/elasticsearch` (which is
-  still in pre-release).
+* Add initial support for version 8 of `@elastic/elasticsearch`, which is
+  still in pre-release. ({pull}2385[#2385])
 
 [float]
 ===== Bug fixes

docs/fastify.asciidoc

@@ -121,6 +121,7 @@ include::./shared-set-up.asciidoc[tag=add-your-own-data]
 ==== Compatibility
 
 include::./shared-set-up.asciidoc[tag=compatibility-link]
+See also: https://www.fastify.io/docs/latest/LTS/[Fastify's own LTS documentation.]
 
 [float]
 [[fastify-troubleshooting]]

docs/supported-technologies.asciidoc

@@ -46,7 +46,7 @@ These are the frameworks that we officially support:
 router information for full support. We currently support the most popular Koa router called
 https://github.com/alexmingoia/koa-router[koa-router].
 |<<restify,Restify>> |>=5.2.0
-|<<fastify,Fastify>> |>=0.27.0
+|<<fastify,Fastify>> |>=1.0.0; see also https://www.fastify.io/docs/latest/LTS/[Fastify's own LTS documentation]
 |=======================================================================
 
 [float]

lib/instrumentation/modules/fastify.js

@@ -1,5 +1,8 @@
 'use strict'
 
+// Instrumentation of fastify.
+// https://www.fastify.io/docs/latest/LTS/
+
 const semver = require('semver')
 
 module.exports = function (fastify, agent, { version, enabled }) {

test/instrumentation/modules/hapi/shared.js

@@ -524,9 +524,16 @@ module.exports = (moduleName) => {
   })
 
   function makeServer (opts) {
-    var server = new Hapi.Server({ host: 'localhost' })
+    // Specify 'localhost' to avoid Hapi default of '0.0.0.0' which ties to
+    // IPv4. We want a later HTTP client request using 'localhost' to work.
+    var server
     if (semver.satisfies(pkg.version, '<17')) {
+      server = new Hapi.Server()
+      opts = opts || {}
+      opts.host = opts.host || 'localhost'
       server.connection(opts)
+    } else {
+      server = new Hapi.Server({ host: 'localhost' })
     }
     return server
   }