Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update CI for node v18.0.0 #2652

Merged
merged 2 commits into from
Apr 25, 2022
Merged

chore: update CI for node v18.0.0 #2652

merged 2 commits into from
Apr 25, 2022

Conversation

trentm
Copy link
Member

@trentm trentm commented Apr 20, 2022

Closes: #2650

Checklist

  • Implement code
  • Add CHANGELOG.asciidoc entry

@trentm trentm self-assigned this Apr 20, 2022
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Apr 20, 2022
@apmmachine
Copy link
Contributor

apmmachine commented Apr 20, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-21T20:20:51.213+0000

  • Duration: 87 min 11 sec

Test stats 🧪

Test Results
Failed 0
Passed 246843
Skipped 0
Total 246843

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@trentm
Copy link
Member Author

trentm commented Apr 20, 2022

Jenkins CI tests failed on:

[2022-04-20T17:29:24.572Z] + .ci/scripts/test.sh -b release -t  18
[2022-04-20T17:29:24.572Z] Running Agent tests with node v18 (BUILD_TYPE=release, FORCE=false)
...
[2022-04-20T17:29:24.572Z] .ci/scripts/test.sh:226: main(): DOCKER_COMPOSE_FILE=docker-compose-all.yml
...
[2022-04-20T17:29:24.572Z] .ci/scripts/test.sh:232: main(): NODE_VERSION=18
...
[2022-04-20T17:29:24.572Z] .ci/scripts/test.sh:232: main(): docker-compose --no-ansi --log-level ERROR -f .ci/docker/docker-compose-all.yml build
[2022-04-20T17:29:26.497Z] .ci/scripts/test.sh:244: main(): '[' 1 -gt 0 ']'
[2022-04-20T17:29:26.497Z] .ci/scripts/test.sh:245: main(): echo 'Docker compose failed, see the below log output'
[2022-04-20T17:29:26.497Z] Docker compose failed, see the below log output

Because (as with earlier major first releases), there isn't yet a published "node:18" to Docker Hub: https://hub.docker.com/_/node

Last time this took a day or three, IIRC.

Note that the GH Actions test of node 18 worked.

@trentm
Copy link
Member Author

trentm commented Apr 20, 2022

Note that the GH Actions test of node 18 worked.

I would be in favour of our Jenkins CI tests not depending on node:* docker images for testing that version of node and instead doing what GH Action's "setup-node" action is doing:

Acquiring 18.0.0 - x64 from https://github.com/actions/node-versions/releases/download/18.0.0-2193993879/node-18.0.0-linux-x64.tar.gz
Extracting ...
/usr/bin/tar xz --strip 1 --warning=no-unknown-keyword -C /home/runner/work/_temp/37ea3dd2-f17e-4539-86e6-c783a5afbef2 -f /home/runner/work/_temp/7314e7fa-5e6d-4642-a566-8bbf67743b74

The build and publish of "node:*" images to Docker Hub is a separate process to the Node core team doing a release. If the former fails or is delayed a long time... we won't be testing with the latest release of node. Anyway... for another issue, unless the delay in getting node:18 drags on.

@trentm
Copy link
Member Author

trentm commented Apr 21, 2022

/test

@trentm
Copy link
Member Author

trentm commented Apr 21, 2022

run module tests for ALL

@trentm trentm requested a review from astorm April 25, 2022 17:06
@trentm trentm merged commit cf61b9e into main Apr 25, 2022
@trentm trentm deleted the trentm/node-v18-in-ci branch April 25, 2022 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update CI to test node v18.0.0
3 participants