add support for 'exts_default_options' easyconfig parameter#2345
Merged
wpoely86 merged 2 commits intoeasybuilders:developfrom Nov 17, 2017
Merged
add support for 'exts_default_options' easyconfig parameter#2345wpoely86 merged 2 commits intoeasybuilders:developfrom
wpoely86 merged 2 commits intoeasybuilders:developfrom
Conversation
wpoely86
reviewed
Nov 17, 2017
test/framework/easyconfig.py
Outdated
| 'toolchain = {"name": "dummy", "version": "dummy"}', | ||
| 'exts_default_options = {', | ||
| ' "source_tmpl": "gzip-1.4.eb",', # dummy source template to avoid downloading fail | ||
| ' "source_urls": ["http://example.com/"]', |
Member
There was a problem hiding this comment.
add something with a %(...)s too?
wpoely86
approved these changes
Nov 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently use something like this in some easyconfig that have a long list of extensions (e.g.
R):(where
ext_optionsis just a local variable in the easyconfig file, EasyBuild itself ignores it when parsing)In places where we need to list additional options, we do ugly things like:
This change adds support for
exts_default_options, which cleans up this mess thoroughly, as follows:This is particularly useful when we want to enforce having checksums for all extensions...