Skip to content

{lang}[foss/2017b] R v3.4.3#5457

Closed
Helios07 wants to merge 4 commits intoeasybuilders:developfrom
Helios07:20171204123813_new_pr_R343
Closed

{lang}[foss/2017b] R v3.4.3#5457
Helios07 wants to merge 4 commits intoeasybuilders:developfrom
Helios07:20171204123813_new_pr_R343

Conversation

@Helios07
Copy link
Copy Markdown

@Helios07 Helios07 commented Dec 4, 2017

(created using eb --new-pr)
'Depends on #5443

@boegel boegel added this to the 3.5.0 milestone Dec 4, 2017
@boegel boegel added the update label Dec 4, 2017
@easybuilders easybuilders deleted a comment from boegelbot Dec 4, 2017
@verdurin
Copy link
Copy Markdown
Member

verdurin commented Dec 5, 2017

Test report by @verdurin
FAILED
Build succeeded for 22 out of 28 (1 easyconfigs in this PR)
dell.lan - Linux fedora 27, Intel(R) Core(TM) i7-4600U CPU @ 2.10GHz, Python 2.7.14
See https://gist.github.com/f8515b014b629aca9874e47c26eff735 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 5, 2017

@Helios07 I just updated #5360 last night to R 3.4.3 as well.

Do you mind syncing up your easyconfig with that one, in terms of dependencies & (more importantly) extensions?

@Helios07
Copy link
Copy Markdown
Author

Helios07 commented Dec 6, 2017

I tried to synchronize the dependencies as far as possible and added checksums to the extensions. I did not compare them one by one, but the versions should be up to date.

@boegelbot
Copy link
Copy Markdown
Collaborator

Travis test report: 8/8 runs failed - see https://travis-ci.org/easybuilders/easybuild-easyconfigs/builds/312276085

Only showing partial log for 1st failed test suite run 7060.1;
full log at https://travis-ci.org/easybuilders/easybuild-easyconfigs/jobs/312276086

...
FAIL: Check the easyconfigs for style
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/easybuilders/easybuild-easyconfigs/test/easyconfigs/styletests.py", line 61, in test_style_conformance
    self.assertEqual(result, 0, "Found code style errors (and/or warnings): %s" % result)
AssertionError: Found code style errors (and/or warnings): 483

----------------------------------------------------------------------
Ran 8044 tests in 417.174s

FAILED (failures=1)
ERROR: Not all tests were successful.

(bleep, bloop, I'm just a bot, please talk to my owner @boegel if you notice you me acting stupid)

('GMP', '6.1.2'), # for igraph
('NLopt', '2.4.2'), # for nloptr
('FFTW', '3.3.6'), # for fftw
('libsndfile', '1.0.28'), # for seewave
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double space required before inline comment

osdependencies = [('openssl-devel', 'libssl-dev', 'libopenssl-devel')]

name_tmpl = '%(name)s_%(version)s.tar.gz'
ext_options = {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use the new exts_default_options construct added in easybuilders/easybuild-framework#2345, see also easyconfig for R 3.4.3 that just got merged.

The easiest way to tackle this is probably to copy the contents from https://github.com/easybuilders/easybuild-easyconfigs/blob/develop/easybuild/easyconfigs/r/R/R-3.4.3-intel-2017b-X11-20171023.eb, and change the toolchain to foss. By preference, use the same dependency versions (it sort of useful to keep easyconfigs consistent between the foss and intel common toolchains).

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to copy your easyconfig file for intel2017b, but this is not building because it tries do download the extensions from http://cran.us.r-project.org/src/base/ instead of http://cran.r-project.org/src/contrib/. I have no idea, why.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Helios07 If you're not using current develop of EasyBuild (which will become v3.5.0 very soon), exts_default_options will be ignored because it's not a known easyconfig parameter yet in EasyBuild v3.4.1 & earlier, and so extensions will be downloaded via the 'parent' source_urls.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installing the development version did not work in time. I will close this PR and try again after 3.5.0 is released.

@Helios07 Helios07 closed this Dec 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants