{bio}[intel/2017a] crb-blast 0.6.9 w/ Ruby-2.5.0 (REVIEW)#5124
{bio}[intel/2017a] crb-blast 0.6.9 w/ Ruby-2.5.0 (REVIEW)#5124boegel merged 4 commits intoeasybuilders:developfrom
Conversation
|
Test report by @verdurin |
| sanity_check_paths = { | ||
| 'files': ['bin/%s' % x for x in ['bioruby', 'br_biofetch.rb', 'br_bioflat.rb', 'br_biogetseq.rb', 'br_pmfetch.rb', | ||
| 'crb-blast']], | ||
| 'dirs': ['gems'], |
There was a problem hiding this comment.
@hajgato Problem with the sanity_check:
== 2017-09-15 16:29:13,954 build_log.py:157 ERROR EasyBuild crashed with an error (at ?:124 in __init__): Sanity check failed: no (non-empty) directory of ('gems',) in /camp/apps/eb/review/software/crb-blast/0.6.9-intel-2017a-Ruby-2.3.4 (at easybuild/framework/easyblock.py:2182 in _sanity_check_step)
There was a problem hiding this comment.
@verdurin Without RubyGem EasyBlock update (easybuilders/easybuild-easyblocks#1247), the gems are installed into the Ruby root directory (which we want to avoid)
| toolchain = {'name': 'intel', 'version': '2017a'} | ||
|
|
||
| dependencies = [ | ||
| ('Ruby', rubyver, '', True), |
There was a problem hiding this comment.
The Ruby built with dummy was required for FPM, but in this case we should prefer a non-dummy Ruby (e.g. #5573)
| CRB-BLAST is a novel method for finding orthologs between one set of sequences and another. | ||
| This is particularly useful in genome and transcriptome annotation.""" | ||
|
|
||
| toolchain = {'name': 'intel', 'version': '2017a'} |
| version = '0.6.9' | ||
|
|
||
| rubyver = '2.3.4' | ||
| versionsuffix = '-Ruby-%s' % rubyver |
There was a problem hiding this comment.
I would just drop the versionsuffix in this case...
| ('BLAST+', '2.6.0', '-Python-2.7.13'), | ||
| ] | ||
|
|
||
| ext_options = { |
There was a problem hiding this comment.
You can/should use the new exts_default_options here (available since EasyBuild v3.5.0, cfr. easybuilders/easybuild-framework#2345)
|
@boegel comments implemented. |
boegel
changed the title
boegel
changed the title
boegel
dismissed
verdurin’s stale review
all's good on top of easybuilders/easybuild-easyblocks#1247
|
Test report by @boegel |
|
Test report by @boegel |
|
Going in, thanks @hajgato! |
3 participants
needs
easybuilders/easybuild-easyblocks#1247