Skip to content

Eliminate dependency on problematic LibUUID library.#6963

Merged
boegel merged 3 commits intoeasybuilders:developfrom
schiotz:eliminate_libuuid
Oct 5, 2018
Merged

Eliminate dependency on problematic LibUUID library.#6963
boegel merged 3 commits intoeasybuilders:developfrom
schiotz:eliminate_libuuid

Conversation

@schiotz
Copy link
Copy Markdown
Contributor

@schiotz schiotz commented Oct 5, 2018

This removes LibUUID which causes several system programs to fail, see discussion on the mailing list:
https://lists.ugent.be/wws/arc/easybuild/2018-10/msg00011.html

The dependency of LibUUID is replaced by util-linux. The change only affects fontconfig-2.13.0 as older versions do not depend on LibUUID. Rebuilding this module is enough to solve the issues, no need to rebuild the entire X11 stack.

CC: @OleHolmNielsen

@boegel boegel added the bug fix label Oct 5, 2018
@boegel boegel added this to the 3.7.1 milestone Oct 5, 2018
boegel
boegel approved these changes Oct 5, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

boegel
boegel requested changes Oct 5, 2018
View reviewed changes
easybuild/easyconfigs/f/fontconfig/fontconfig-2.13.0-GCCcore-6.4.0.eb Outdated
('expat', '2.2.5'),
('freetype', '2.9'),
('LibUUID', '1.0.3'),
('util-linux', '2.32.1'),
Copy link
Copy Markdown
Member

@boegel boegel Oct 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@schiotz This should be '2.31.1' (since this version is already used as dependency in easyconfigs using a toolchain from the 2018a generation), tests will most likely fail without fixing this.

Copy link
Copy Markdown
Contributor Author

@schiotz schiotz Oct 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@boegel Done.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 5, 2018

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (2 easyconfigs in this PR)
node3101.skitty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/cd5227a2e21638bc0db50f605fccbcc9 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 5, 2018

Test report by @boegel
SUCCESS
Build succeeded for 3 out of 3 (2 easyconfigs in this PR)
node2674.swalot.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/4e213201d6c3039ace4c7f629b988025 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 5, 2018

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2058.delcatty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/8fb6888ec839b8d2e7472a673dc1f5c9 for a full test report.

boegel
boegel previously approved these changes Oct 5, 2018
View reviewed changes
@schiotz
Copy link
Copy Markdown
Contributor Author

schiotz commented Oct 5, 2018

Judging from the test, I should downgrade the foss/2018b version, too.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 5, 2018

@schiotz Yes, indeed, we should stick to util-linux 2.32 for the 2018b toolchain generation...

@easybuilders easybuilders deleted a comment from boegelbot Oct 5, 2018
@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 5, 2018

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node3101.skitty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6140 CPU @ 2.30GHz, Python 2.7.5
See https://gist.github.com/b99e4aeae8a1ef362e5e47427e2d34b8 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 5, 2018

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2683.swalot.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2660 v3 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/5f136ca6b3961d6d4b069fb4b351f35f for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 5, 2018

Test report by @boegel
SUCCESS
Build succeeded for 2 out of 2 (2 easyconfigs in this PR)
node2002.delcatty.os - Linux centos linux 7.5.1804, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/2ceea092e0fe0e690efdd684258dbe6d for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Oct 5, 2018

Going in, thanks @schiotz!

@boegel boegel merged commit 91b277e into easybuilders:develop Oct 5, 2018
@boegel boegel mentioned this pull request Oct 5, 2018
Closed
@boegel boegel mentioned this pull request Oct 16, 2018
Merged
@hajgato hajgato mentioned this pull request Dec 7, 2018
Closed
@hajgato hajgato mentioned this pull request Jan 30, 2019
Merged
boegel added a commit to boegel/easybuild-easyconfigs that referenced this pull request May 7, 2019
@boegel
replace LibUUID dependencies with util-linux (cfr. easybuilders#6963)
80e208e
@boegel boegel mentioned this pull request May 7, 2019
Merged
smoors added a commit that referenced this pull request May 7, 2019
@smoors
Merge pull request #8258 from boegel/no_more_libuuid
c3a5b5a 
replace LibUUID dependencies with util-linux (cfr. #6963)
@boegel boegel mentioned this pull request Mar 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

3.7.1

Development

Successfully merging this pull request may close these issues.

2 participants

@schiotz @boegel