Skip to content

replace LibUUID dependencies with util-linux (cfr. #6963)#8258

Merged
smoors merged 2 commits intoeasybuilders:developfrom
boegel:no_more_libuuid
May 7, 2019
Merged

replace LibUUID dependencies with util-linux (cfr. #6963)#8258
smoors merged 2 commits intoeasybuilders:developfrom
boegel:no_more_libuuid

Conversation

@boegel
Copy link
Copy Markdown
Member

@boegel boegel commented May 7, 2019

No description provided.

@boegel boegel added the bug fix label May 7, 2019
@boegel boegel added this to the next release (3.9.1) milestone May 7, 2019
@boegel boegel mentioned this pull request May 7, 2019
Merged
@boegel boegel requested a review from smoors May 7, 2019 13:31
@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 7, 2019

Submitting a test report for this is likely going to be painful due to the old toolchain versions involved, so I'll look into a full test report (on our oldest cluster).

Maybe others should only submit a partial test report using eb --from-pr 8258 libdap-3.20.3-GCCcore-7.3.0.eb libdap-3.19.1-GCCcore-6.4.0.eb for example...

@easybuilders easybuilders deleted a comment from boegelbot May 7, 2019
@boegel
Copy link
Copy Markdown
Member Author

boegel commented May 7, 2019

Test report by @boegel
SUCCESS
Build succeeded for 7 out of 7 (7 easyconfigs in this PR)
node2024.delcatty.os - Linux centos linux 7.6.1810, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/4db00956ebfe885b9441db974b61cd96 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented May 7, 2019

Test report by @smoors
FAILED
Build succeeded for 1 out of 6 (5 easyconfigs in this PR)
nic31 - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/30383482a534d7252568299d4ce5ef99 for a full test report.

@smoors
Copy link
Copy Markdown
Contributor

smoors commented May 7, 2019

Test report by @smoors
SUCCESS
Build succeeded for 6 out of 6 (5 easyconfigs in this PR)
nic425 - Linux centos linux 7.5.1804, Intel(R) Xeon(R) Gold 6148 CPU @ 2.40GHz, Python 2.7.5
See https://gist.github.com/bdff08c7ee3c68da7b597d7ac5163685 for a full test report.

smoors
smoors approved these changes May 7, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@smoors smoors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smoors
Copy link
Copy Markdown
Contributor

smoors commented May 7, 2019

Going in, thanks @boegel!

@smoors smoors merged commit c3a5b5a into easybuilders:develop May 7, 2019
@boegel boegel deleted the no_more_libuuid branch May 7, 2019 17:56
@boegel boegel mentioned this pull request Oct 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@smoors smoors smoors approved these changes

Assignees

No one assigned

Labels

bug fix

Projects

None yet

Milestone

3.9.1

Development

Successfully merging this pull request may close these issues.

2 participants

@boegel @smoors