Skip to content

{vis}[foss/2017b] Tk v8.6.7#5443

Merged
boegel merged 3 commits intoeasybuilders:developfrom
Helios07:20171201101341_new_pr_Tk867
Dec 4, 2017
Merged

{vis}[foss/2017b] Tk v8.6.7#5443
boegel merged 3 commits intoeasybuilders:developfrom
Helios07:20171201101341_new_pr_Tk867

Conversation

@Helios07
Copy link
Copy Markdown

@Helios07 Helios07 commented Dec 1, 2017

(created using eb --new-pr)

boegel
boegel requested changes Dec 3, 2017
View reviewed changes
easybuild/easyconfigs/t/Tk/Tk-8.6.7-foss-2017b.eb

dependencies = [
('Tcl', version),
('zlib', '1.2.11'),
Copy link
Copy Markdown
Member

@boegel boegel Dec 3, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Helios07 This should include a dependency on X11, see recent Tk easyconfigs and discussion in #3864 and #3957

@boegel boegel added this to the 3.5.0 milestone Dec 3, 2017
@boegel boegel added the update label Dec 3, 2017
@Helios07 Helios07 mentioned this pull request Dec 4, 2017
Closed
boegel
boegel requested changes Dec 4, 2017
View reviewed changes
easybuild/easyconfigs/t/Tk/Tk-8.6.7-foss-2017b.eb
sources = ['%(namelower)s%(version)s-src.tar.gz']
checksums = ['061de2a354f9b7c7d04de3984c90c9bc6dd3a1b8377bb45509f1ad8a8d6337aa']

patches = ['Tk-8.6.4_different-prefix-with-tcl.patch']
Copy link
Copy Markdown
Member

@boegel boegel Dec 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Helios07 style remark: please move this up, and also include a SHA256 checksum for the patch (--include-checksums will do that for you)

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 4, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2011.delcatty.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz, Python 2.7.5
See https://gist.github.com/a5913c5978e109e05de09a359eb131a8 for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 4, 2017

Test report by @boegel
SUCCESS
Build succeeded for 1 out of 1 (1 easyconfigs in this PR)
node2404.golett.os - Linux centos linux 7.4.1708, Intel(R) Xeon(R) CPU E5-2680 v3 @ 2.50GHz, Python 2.7.5
See https://gist.github.com/24508569bd15c07dcfc3be5e6da96c5e for a full test report.

@boegel
Copy link
Copy Markdown
Member

boegel commented Dec 4, 2017

Going in, thanks @Helios07!

@boegel boegel merged commit fb68460 into easybuilders:develop Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@boegel boegel boegel approved these changes

Assignees

No one assigned

Labels

update

Projects

None yet

Milestone

3.5.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Helios07 @boegel