[workloads] Add Current to the name of the workload manifest #80401
Conversation
dotnet/sdk@f5cb7e3 introduced a change that would make `microsoft.net.workload.mono.toolchain` an outdated id in order to work around manifest errors when older previews of the .NET 7 SDK were installed. The unfortunate side effect of this change means the name of the manifest needs to be changed. On the main branch, the manifest id will now contain current in the name for the .net version being developed.
steveisok
requested review from
lewing,
radical,
pavelsavara and
marek-safar
as code owners
ghost
assigned 
|
Tagging subscribers to this area: @directhex Issue Detailsdotnet/sdk@f5cb7e3 introduced a change that would make On the main branch, the manifest id will now contain current in the name for the .net version being developed.
|
There was a problem hiding this comment.
I think you'll have to update
runtime/src/workloads/workloads.csproj
Line 127 in 78f5a98
|
I think we want to do the preview tagging before we do this? |
|
@radical please take a look at what we need to do to make wbt happy |
|
The generated package is |
|
And the message says |
| @@ -11,6 +11,7 @@ | |||
| <PackageVersionNet7>7.0.0</PackageVersionNet7> | |||
| <PreReleaseVersionLabel>alpha</PreReleaseVersionLabel> | |||
There was a problem hiding this comment.
Should this be changing to preview too?
.. change. The workload manifest has `.Current` added to the name now. This makes the older name `microsoft.net.workload.mono.toolchain` invalid. But sdk still installs this, which breaks the workload. - As a workaround for the tests, remove manifest directory - Also, update the name in the `IncludedWorkloadManifests.txt`
|
Needs updated packages from dotnet/emsdk#276 . |
src/mono/nuget/Microsoft.NET.Workload.Mono.Toolchain.Current.Manifest/WorkloadManifest.json.in
Show resolved
Hide resolved
|
we'll need to update the emsdk subscription and InstalledManifests.txt in |
|
We're blocking installer now dotnet/installer#15346 (comment) |
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
installer followup dotnet/installer#15366 |
|
I reran a couple of lanes but the failures were not related |
dotnet/sdk@f5cb7e3 introduced a change that would make
microsoft.net.workload.mono.toolchainan outdated id in order to work around manifest errors when older previews of the .NET 7 SDK were installed. The unfortunate side effect of this change meant the name of the runtime manifest needs to be changed.On the main branch, the manifest id will now contain current in the name for the .net version being developed.