-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update emsdk manifest dependency name to Microsoft.NET.Workload.Emscr… #81235
Conversation
…ipten.Current.Manifest-8.0.100-preview1 .. and updated the version with darc from channel `".NET 8"`.
Tagging subscribers to 'arch-wasm': @lewing Issue Details…ipten.Current.Manifest-8.0.100-preview1 .. and updated the version with darc from channel
|
Should this instead go in #80401? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to update Versions.props with the new property name too
Yeah, because we can get everything we need in one PR. |
Closing to merge the changes in to #80401 . |
@marcpopMSFT @dsplaisted this is going to be painful to update |
@lewing what's going to be the painful part and how can we help? |
@marcpopMSFT that because the preview name is now in the package name we will have to manually update the darc subscription every preview |
and it looks like the sdk is only looking in its band so it is looking in cc @mmitche |
Closing in favor of #80401 . |
…ipten.Current.Manifest-8.0.100-preview1
.. and updated the version with darc from channel
".NET 8"
.