Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] Update dependencies from dotnet/sdk #15346

Merged
merged 18 commits into from
Jan 27, 2023

Conversation

dotnet-maestro[bot]
Copy link

@dotnet-maestro dotnet-maestro bot commented Jan 25, 2023

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

  • Coherency Updates:
    • Microsoft.WindowsDesktop.App.Ref: from 8.0.0-alpha.1.23074.1 to 8.0.0-alpha.1.23076.3 (parent: Microsoft.NET.Sdk)
    • VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0: from 8.0.0-alpha.1.23074.1 to 8.0.0-alpha.1.23076.3 (parent: Microsoft.NET.Sdk)
    • VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0: from 8.0.0-alpha.1.23074.1 to 8.0.0-alpha.1.23076.3 (parent: Microsoft.NET.Sdk)
    • VS.Redist.Common.NetCore.SharedFramework.x64.8.0: from 8.0.0-alpha.1.23074.4 to 8.0.0-alpha.1.23076.9 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.App.Ref: from 8.0.0-alpha.1.23074.4 to 8.0.0-alpha.1.23076.9 (parent: Microsoft.NET.Sdk)
    • VS.Redist.Common.NetCore.TargetingPack.x64.8.0: from 8.0.0-alpha.1.23074.4 to 8.0.0-alpha.1.23076.9 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.App.Runtime.win-x64: from 8.0.0-alpha.1.23074.4 to 8.0.0-alpha.1.23076.9 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.App.Host.win-x64: from 8.0.0-alpha.1.23074.4 to 8.0.0-alpha.1.23076.9 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.DotNetHostResolver: from 8.0.0-alpha.1.23074.4 to 8.0.0-alpha.1.23076.9 (parent: Microsoft.NET.Sdk)
    • Microsoft.NETCore.Platforms: from 8.0.0-alpha.1.23074.4 to 8.0.0-alpha.1.23076.9 (parent: Microsoft.NET.Sdk)
    • Microsoft.AspNetCore.App.Ref: from 8.0.0-alpha.1.23075.1 to 8.0.0-alpha.1.23076.8 (parent: Microsoft.NET.Sdk)
    • Microsoft.AspNetCore.App.Ref.Internal: from 8.0.0-alpha.1.23075.1 to 8.0.0-alpha.1.23076.8 (parent: Microsoft.NET.Sdk)
    • Microsoft.AspNetCore.App.Runtime.win-x64: from 8.0.0-alpha.1.23075.1 to 8.0.0-alpha.1.23076.8 (parent: Microsoft.NET.Sdk)
    • VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0: from 8.0.0-alpha.1.23075.1 to 8.0.0-alpha.1.23076.8 (parent: Microsoft.NET.Sdk)
    • dotnet-dev-certs: from 8.0.0-alpha.1.23075.1 to 8.0.0-alpha.1.23076.8 (parent: Microsoft.NET.Sdk)
    • dotnet-user-jwts: from 8.0.0-alpha.1.23075.1 to 8.0.0-alpha.1.23076.8 (parent: Microsoft.NET.Sdk)
    • dotnet-user-secrets: from 8.0.0-alpha.1.23075.1 to 8.0.0-alpha.1.23076.8 (parent: Microsoft.NET.Sdk)
    • Microsoft.WindowsDesktop.App.Runtime.win-x64: from 8.0.0-alpha.1.23074.1 to 8.0.0-alpha.1.23076.3 (parent: Microsoft.NET.Sdk)
    • Microsoft.Dotnet.WinForms.ProjectTemplates: from 8.0.0-alpha.1.23067.2 to 8.0.0-alpha.1.23075.2 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)
    • Microsoft.WindowsDesktop.App.Runtime.win-x64: from 8.0.0-alpha.1.23074.1 to 8.0.0-alpha.1.23076.3 (parent: Microsoft.NET.Sdk)
    • Microsoft.DotNet.Wpf.ProjectTemplates: from 8.0.0-alpha.1.23068.4 to 8.0.0-alpha.1.23076.1 (parent: Microsoft.WindowsDesktop.App.Runtime.win-x64)
    • Microsoft.NET.Test.Sdk: from 17.6.0-preview-20230123-01 to 17.6.0-preview-20230126-02 (parent: Microsoft.NET.Sdk)
    • Microsoft.Net.Compilers.Toolset: from 4.5.0-3.23070.7 to 4.5.0-3.23075.2 (parent: Microsoft.NET.Sdk)
    • Microsoft.Build: from 17.6.0-preview-23074-01 to 17.6.0-preview-23076-08 (parent: Microsoft.NET.Sdk)
    • NuGet.Build.Tasks: from 6.5.0-preview.3.136 to 6.5.0-rc.149 (parent: Microsoft.NET.Sdk)

From https://github.com/dotnet/sdk

  • Subscription: f5e16d6d-e643-4370-f3ed-08d8e97c775d
  • Build: 20230127.4
  • Date Produced: January 27, 2023 6:05:42 PM UTC
  • Commit: 33d4e69
  • Branch: refs/heads/main

@dotnet-maestro
Copy link
Author

Notification for subscribed users from https://github.com/dotnet/sdk:

@dotnet/domestic-cat

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

  • This pull request contains changes from your source repo (https://github.com/dotnet/sdk) and seems to have failed checks in this PR. Please take a peek at the failures and comment if they seem relevant to your changes.
  • If you're being tagged in this comment it is due to an entry in the related Maestro Subscription of the Build Asset Registry. If you feel this entry has added your GitHub login or your GitHub team in error, please update the subscription to reflect this.
  • For more details, please read the Arcade Darc documentation

@joeloff
Copy link
Member

joeloff commented Jan 25, 2023

This is a result of the Arcade changes changing the name of the installer packages for the manifest MSIs.

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-alpha.1.23075.4 -> To Version 8.0.100-alpha.1.23075.5

Dependency coherency updates

VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms
 From Version 8.0.0-alpha.1.23074.4 -> To Version 8.0.0-alpha.1.23075.1 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-alpha.1.23075.4 -> To Version 8.0.100-alpha.1.23075.11

Dependency coherency updates

VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.NET.Test.Sdk,Microsoft.Build
 From Version 8.0.0-alpha.1.23074.4 -> To Version 8.0.0-alpha.1.23075.1 (parent: Microsoft.NET.Sdk
@joeloff joeloff force-pushed the darc-main-ea61cf66-f97e-49a3-955b-fbbd20692f70 branch from 67c728a to 0163530 Compare January 25, 2023 22:22
dotnet-maestro bot and others added 5 commits January 25, 2023 23:07
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-alpha.1.23075.4 -> To Version 8.0.100-alpha.1.23075.15

Dependency coherency updates

VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.NET.Test.Sdk,Microsoft.Build
 From Version 8.0.0-alpha.1.23074.4 -> To Version 8.0.0-alpha.1.23075.1 (parent: Microsoft.NET.Sdk
@joeloff
Copy link
Member

joeloff commented Jan 26, 2023

@MichaelSimons can you help with the source build failure?

@MichaelSimons
Copy link
Member

@wtgodbe, @dougbu - Can you help with this aspnetcore failure in the source-build leg?

    /vmr/src/aspnetcore/artifacts/source-build/self/src/src/Servers/Kestrel/Core/src/Internal/TlsConnectionFeature.cs(128,19): error CA1416: This call site is reachable on all platforms. 'SslStream.NegotiateClientCertificateAsync(CancellationToken)' is only supported on: 'freebsd', 'linux', 'windows'. [/vmr/src/aspnetcore/artifacts/source-build/self/src/src/Servers/Kestrel/Core/src/Microsoft.AspNetCore.Server.Kestrel.Core.csproj]

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-alpha.1.23075.4 -> To Version 8.0.100-alpha.1.23076.1

Dependency coherency updates

VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.NET.Test.Sdk,Microsoft.Build
 From Version 8.0.0-alpha.1.23074.4 -> To Version 8.0.0-alpha.1.23075.6 (parent: Microsoft.NET.Sdk
@kasperk81
Copy link

same error in dotnet/aspnetcore#46269. if aspnetcore will end up suppressing ca1416 then it can be patched here to unblock this pr.

@wtgodbe
Copy link
Member

wtgodbe commented Jan 26, 2023

I'll work with the area owner to figure out how we want to fix the error in aspnetcore

@dougbu
Copy link
Member

dougbu commented Jan 26, 2023

I'll work with the area owner to figure out how we want to fix the error in aspnetcore

/cc @JamesNK @Tratcher

Separately, what allowed us to reach the point where this error shows up in the installer repo❔ Are we working here w/ a newer runtime than aspnetcore built against for example❔

@mmitche
Copy link
Member

mmitche commented Jan 26, 2023

I'll work with the area owner to figure out how we want to fix the error in aspnetcore

/cc @JamesNK @Tratcher

Separately, what allowed us to reach the point where this error shows up in the installer repo❔ Are we working here w/ a newer runtime than aspnetcore built against for example❔

That's probably it. Either way could happen of course. Aspnet could react to a new API change that has not flowed to SDK yet, or aspnet may not have reacted to an API change that already flowed to SDK.

One 'solution' to this would be to coherency tie sdk's runtime to aspnet's. I've resisted temptations to do this, because:

  • It preferences aspnet over windowsdesktop, which feels wrong
  • Has the potential to slow down dependency flow even when there would not be a break, if aspnet itself has a break or is slow to uptake new runtimes. If most updates go just fine, why enforce strict coherency.

/cc @MichaelSimons @marcpopMSFT

@marcpopMSFT
Copy link
Member

Do we know how often ASPNET being ahead of Runtime is actually safe incoherency? I assume not frequently as I'm pretty sure most breaks I've seen to installer that were coherency related were ASPNET net being ahead of Runtime. We used to have a test that would catch it because when you tried dotnet run, it would fail to find the runtime. Haven't see that particular failure for a while so something might have changed.

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-alpha.1.23075.4 -> To Version 8.0.100-alpha.1.23076.2

Dependency coherency updates

VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.NET.Test.Sdk,Microsoft.Build
 From Version 8.0.0-alpha.1.23074.4 -> To Version 8.0.0-alpha.1.23075.6 (parent: Microsoft.NET.Sdk
@mmitche
Copy link
Member

mmitche commented Jan 26, 2023

Do we know how often ASPNET being ahead of Runtime is actually safe incoherency? I assume not frequently as I'm pretty sure most breaks I've seen to installer that were coherency related were ASPNET net being ahead of Runtime. We used to have a test that would catch it because when you tried dotnet run, it would fail to find the runtime. Haven't see that particular failure for a while so something might have changed.

I saw a break in a test because of incoherency a few days ago. It was in the deb installers though. It wasn't strictly incoherency, just that the version available from the sdk was older than what aspnetcore wanted. The debian package installers would roll forward on versions but not back.

The most conservative approach would be exact coherency. But exact coherency is not possible without a lot of complex infra because of the diamond pattern formed by runtime->windowsdesktop->sdk and runtime->aspnetcore->sdk

dotnet-maestro bot and others added 4 commits January 26, 2023 20:06
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-alpha.1.23075.4 -> To Version 8.0.100-alpha.1.23076.4

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.NET.Test.Sdk,Microsoft.Net.Compilers.Toolset,Microsoft.Build
 From Version 8.0.0-alpha.1.23074.1 -> To Version 8.0.0-alpha.1.23075.2 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-alpha.1.23075.4 -> To Version 8.0.100-alpha.1.23076.5

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.NET.Test.Sdk,Microsoft.Net.Compilers.Toolset,Microsoft.Build
 From Version 8.0.0-alpha.1.23074.1 -> To Version 8.0.0-alpha.1.23075.2 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-alpha.1.23075.4 -> To Version 8.0.100-alpha.1.23076.7

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.NET.Test.Sdk,Microsoft.Net.Compilers.Toolset,Microsoft.Build
 From Version 8.0.0-alpha.1.23074.1 -> To Version 8.0.0-alpha.1.23075.2 (parent: Microsoft.NET.Sdk
@mmitche mmitche requested a review from a team as a code owner January 27, 2023 00:19
@mmitche
Copy link
Member

mmitche commented Jan 27, 2023

Removed integrated razor patch

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-alpha.1.23075.4 -> To Version 8.0.100-alpha.1.23076.8

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.NET.Test.Sdk,Microsoft.Net.Compilers.Toolset,Microsoft.Build
 From Version 8.0.0-alpha.1.23074.1 -> To Version 8.0.0-alpha.1.23075.2 (parent: Microsoft.NET.Sdk
@kasperk81
Copy link

dotnet/sdk#30160 has the fix

Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-alpha.1.23075.4 -> To Version 8.0.100-alpha.1.23077.1

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.NET.Test.Sdk,Microsoft.Net.Compilers.Toolset,Microsoft.Build
 From Version 8.0.0-alpha.1.23074.1 -> To Version 8.0.0-alpha.1.23075.2 (parent: Microsoft.NET.Sdk
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-alpha.1.23075.4 -> To Version 8.0.100-alpha.1.23077.2

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.NET.Test.Sdk,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks
 From Version 8.0.0-alpha.1.23074.1 -> To Version 8.0.0-alpha.1.23076.3 (parent: Microsoft.NET.Sdk
@kasperk81
Copy link

SDK Resolver Failure: "The SDK resolver "Microsoft.DotNet.MSBuildWorkloadSdkResolver" failed while attempting to resolve the SDK "Microsoft.NET.Sdk". Exception: "Microsoft.NET.Sdk.WorkloadManifestReader.WorkloadManifestCompositionException: Workload manifest dependency 'Microsoft.NET.Workload.Emscripten.net7' version '8.0.0-alpha.1.23070.1' is lower than version '8.0.0-alpha.1.23073.2' required by manifest 'microsoft.net.workload.mono.toolchain' [/__w/1/s/artifacts/bin/redist/Debug/dotnet/sdk-manifests/8.0.100/microsoft.net.workload.mono.toolchain/WorkloadManifest.json]

@lewing @radical related to dotnet/runtime#80916 and #15336?

@kasperk81
Copy link

The most conservative approach would be exact coherency. But exact coherency is not possible without a lot of complex infra because of the diamond pattern formed by runtime->windowsdesktop->sdk and runtime->aspnetcore->sdk

anything that simplifies the current situation, e.g. by reducing the number of participating repos in coherency update, is an improvement at this point. having monorepo for the entire dotnet can avoid lots of these headaches but i can tell it's not happening anytime soon. for inspirations: golang, node, llvm and freebsd are all monorepos. that's becoming a popular way to solve "too many repos that nobody is thrilled to maintain as part of their day job" problem.

dotnet-maestro bot and others added 2 commits January 27, 2023 18:21
Microsoft.DotNet.Common.ItemTemplates , Microsoft.DotNet.MSBuildSdkResolver , Microsoft.NET.Sdk , Microsoft.TemplateEngine.Cli
 From Version 8.0.100-alpha.1.23075.4 -> To Version 8.0.100-alpha.1.23077.4

Dependency coherency updates

Microsoft.WindowsDesktop.App.Ref,VS.Redist.Common.WindowsDesktop.SharedFramework.x64.8.0,VS.Redist.Common.WindowsDesktop.TargetingPack.x64.8.0,VS.Redist.Common.NetCore.SharedFramework.x64.8.0,Microsoft.NETCore.App.Ref,VS.Redist.Common.NetCore.TargetingPack.x64.8.0,Microsoft.NETCore.App.Runtime.win-x64,Microsoft.NETCore.App.Host.win-x64,Microsoft.NETCore.DotNetHostResolver,Microsoft.NETCore.Platforms,Microsoft.AspNetCore.App.Ref,Microsoft.AspNetCore.App.Ref.Internal,Microsoft.AspNetCore.App.Runtime.win-x64,VS.Redist.Common.AspNetCore.SharedFramework.x64.8.0,dotnet-dev-certs,dotnet-user-jwts,dotnet-user-secrets,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.Dotnet.WinForms.ProjectTemplates,Microsoft.WindowsDesktop.App.Runtime.win-x64,Microsoft.DotNet.Wpf.ProjectTemplates,Microsoft.NET.Test.Sdk,Microsoft.Net.Compilers.Toolset,Microsoft.Build,NuGet.Build.Tasks
 From Version 8.0.0-alpha.1.23074.1 -> To Version 8.0.0-alpha.1.23076.3 (parent: Microsoft.NET.Sdk
#15361)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
@dotnet-maestro dotnet-maestro bot merged commit 05a1cd2 into main Jan 27, 2023
@dotnet-maestro dotnet-maestro bot deleted the darc-main-ea61cf66-f97e-49a3-955b-fbbd20692f70 branch January 27, 2023 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants