Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional workloads do not work in .NET 8 builds #15348

Closed
jonathanpeppers opened this issue Jan 25, 2023 · 12 comments
Closed

Optional workloads do not work in .NET 8 builds #15348

jonathanpeppers opened this issue Jan 25, 2023 · 12 comments

Comments

@jonathanpeppers
Copy link
Member

Context: dotnet/runtime#80401

dotnet/sdk@f5cb7e3 introduced a change that would make microsoft.net.workload.mono.toolchain an outdated id in order to work around manifest errors when older previews of the .NET 7 SDK were installed.

So for optional workloads to work at all, on CI we had to rename folders such as:

https://github.com/dotnet/maui/blob/eea6fea9897faf736306aeb4c250dafedaac18c9/src/DotNet/DotNet.csproj#L162-L170

Filing this issue to track this problem, as it won't be solved until dotnet/runtime#80401 is merged and flows to dotnet/installer.

At that point we can test the changes further downstream in xamarin-android, xamarin-macios, and dotnet/maui.

@marcpopMSFT
Copy link
Member

Runtime updated their workload ID, I think we just need their workloads to flow and get picked up. CC @steveisok in case there's an update there.

@jonathanpeppers
Copy link
Member Author

I think we're close, they just wanted me to file an issue somewhere to track this.

@jonathanpeppers
Copy link
Member Author

This is now waiting on this to land: #15366

@lewing
Copy link
Member

lewing commented Jan 31, 2023

#1566 is in now

@jonathanpeppers
Copy link
Member Author

I'm now trying the latest dotnet/installer builds at:

dotnet/android#7755

I had to manually fix up $(MicrosoftNETWorkloadEmscriptenCurrentManifest80100alpha1Version) and related values.

@jonathanpeppers
Copy link
Member Author

jonathanpeppers commented Jan 31, 2023

Wait, so we have:

  • Microsoft.NET.Workload.Emscripten.net6.Manifest-8.0.100-alpha.1
  • Microsoft.NET.Workload.Emscripten.net7.Manifest-8.0.100-alpha.1
  • Microsoft.NET.Workload.Emscripten.Current.Manifest-alpha.1
  • Microsoft.NET.Workload.Mono.Toolchain.net6.Manifest-8.0.100-alpha.1
  • Microsoft.NET.Workload.Mono.Toolchain.net7.Manifest-8.0.100-alpha.1
  • Microsoft.NET.Workload.Mono.Toolchain.Current.Manifest-8.0.100-alpha.1

I guess I need more changes in our build to account for the different version bands in .NET 8.

@jonathanpeppers
Copy link
Member Author

dotnet/android#7755 is merged.

When the current build completes, we can try it in dotnet/maui next.

@lewing
Copy link
Member

lewing commented Jan 31, 2023

they will be preview.1 packs once we can produce preview.1 packs, the manual renaming as things flow is a mess

@lewing
Copy link
Member

lewing commented Jan 31, 2023

jonathanpeppers added a commit to jonathanpeppers/maui that referenced this issue Feb 1, 2023
Fixes: dotnet/installer#15348
Changes: dotnet/android@1d7092d...8872d04
Changes: dotnet/installer@779a644...dec1209
Changes: dotnet/runtime@ddb6988...9529803
Changes: dotnet/emsdk@5b46122...0fe864f

Update to latest Android workload and .NET 8 SDK.

This should resolve the issues with workload manifest names.
@jonathanpeppers
Copy link
Member Author

After this one goes in, we can probably branch all the repos for dotnet/maui:

dotnet/maui#13040

mattleibow pushed a commit to dotnet/maui that referenced this issue Feb 1, 2023
…3040)

* Bump to xamarin/xamarin-android/main@8872d04 34.0.0-preview.1.146

Fixes: dotnet/installer#15348
Changes: dotnet/android@1d7092d...8872d04
Changes: dotnet/installer@779a644...dec1209
Changes: dotnet/runtime@ddb6988...9529803
Changes: dotnet/emsdk@5b46122...0fe864f

Update to latest Android workload and .NET 8 SDK.

This should resolve the issues with workload manifest names.

* Update Versions.props

---------

Co-authored-by: Rui Marinho <[email protected]>
@marcpopMSFT
Copy link
Member

@lewing @jonathanpeppers what is left to make this work?

@jonathanpeppers
Copy link
Member Author

I think main is working, but it does not appear to be working in release/8.0.1xx-preview1 yet:

dotnet/android#7760 (comment)

@lewing lewing closed this as completed Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants