-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional workloads do not work in .NET 8 builds #15348
Comments
Runtime updated their workload ID, I think we just need their workloads to flow and get picked up. CC @steveisok in case there's an update there. |
I think we're close, they just wanted me to file an issue somewhere to track this. |
This is now waiting on this to land: #15366 |
#1566 is in now |
I'm now trying the latest dotnet/installer builds at: I had to manually fix up |
Wait, so we have:
I guess I need more changes in our build to account for the different version bands in .NET 8. |
dotnet/android#7755 is merged. When the current build completes, we can try it in dotnet/maui next. |
they will be preview.1 packs once we can produce preview.1 packs, the manual renaming as things flow is a mess |
Fixes: dotnet/installer#15348 Changes: dotnet/android@1d7092d...8872d04 Changes: dotnet/installer@779a644...dec1209 Changes: dotnet/runtime@ddb6988...9529803 Changes: dotnet/emsdk@5b46122...0fe864f Update to latest Android workload and .NET 8 SDK. This should resolve the issues with workload manifest names.
After this one goes in, we can probably branch all the repos for dotnet/maui: |
…3040) * Bump to xamarin/xamarin-android/main@8872d04 34.0.0-preview.1.146 Fixes: dotnet/installer#15348 Changes: dotnet/android@1d7092d...8872d04 Changes: dotnet/installer@779a644...dec1209 Changes: dotnet/runtime@ddb6988...9529803 Changes: dotnet/emsdk@5b46122...0fe864f Update to latest Android workload and .NET 8 SDK. This should resolve the issues with workload manifest names. * Update Versions.props --------- Co-authored-by: Rui Marinho <[email protected]>
@lewing @jonathanpeppers what is left to make this work? |
I think main is working, but it does not appear to be working in |
Context: dotnet/runtime#80401
dotnet/sdk@f5cb7e3 introduced a change that would make
microsoft.net.workload.mono.toolchain
an outdated id in order to work around manifest errors when older previews of the .NET 7 SDK were installed.So for optional workloads to work at all, on CI we had to rename folders such as:
https://github.com/dotnet/maui/blob/eea6fea9897faf736306aeb4c250dafedaac18c9/src/DotNet/DotNet.csproj#L162-L170
Filing this issue to track this problem, as it won't be solved until dotnet/runtime#80401 is merged and flows to dotnet/installer.
At that point we can test the changes further downstream in xamarin-android, xamarin-macios, and dotnet/maui.
The text was updated successfully, but these errors were encountered: