-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Suppress BinSkim BA2008 warning for llvm-mca.exe and FileCheck.exe #119376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot wasn't able to review any files in this pull request.
@AndyAyersMS @jkoritzinsky PTAL. |
gdnbaselines is removed in #104594. So, unlike in dotnet/efcore#36615, we are not doing gdnbaselines update. |
18686ee
to
5280e74
Compare
/ba-g Failures are known issues and not related to this PR. |
/backport to release/10.0 |
Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/17508883758 |
Still waiting for the unified build test is complete to validate the fix. |
In the unified build, binskim still scans the two excluded files. Looking into it further. |
The eng/common files get overriden by the next arcade update. I will put up a new PR that edits dotnet/eng/pipelines/official.yml. |
Replaced with dotnet/dotnet#2339. |
Suppressing BinSkim BA2008 warnings for two external libarries that SuperFileCheck uses.