Skip to content

Conversation

JulieLeeMSFT
Copy link
Member

Suppressing BinSkim BA2008 warnings for two external libarries that SuperFileCheck uses.

@Copilot Copilot AI review requested due to automatic review settings September 5, 2025 00:18
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@github-actions github-actions bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 5, 2025
@JulieLeeMSFT
Copy link
Member Author

@AndyAyersMS @jkoritzinsky PTAL.

@JulieLeeMSFT
Copy link
Member Author

gdnbaselines is removed in #104594. So, unlike in dotnet/efcore#36615, we are not doing gdnbaselines update.

@JulieLeeMSFT JulieLeeMSFT added this to the 10.0.0 milestone Sep 5, 2025
@JulieLeeMSFT
Copy link
Member Author

/ba-g Failures are known issues and not related to this PR.

@JulieLeeMSFT JulieLeeMSFT merged commit 367865b into dotnet:main Sep 6, 2025
146 of 152 checks passed
@JulieLeeMSFT
Copy link
Member Author

/backport to release/10.0

Copy link
Contributor

github-actions bot commented Sep 6, 2025

@JulieLeeMSFT
Copy link
Member Author

Still waiting for the unified build test is complete to validate the fix.

@JulieLeeMSFT
Copy link
Member Author

In the unified build, binskim still scans the two excluded files. Looking into it further.

@JulieLeeMSFT
Copy link
Member Author

The eng/common files get overriden by the next arcade update. I will put up a new PR that edits dotnet/eng/pipelines/official.yml.

@JulieLeeMSFT
Copy link
Member Author

Replaced with dotnet/dotnet#2339.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants