Skip to content

Conversation

@SamMonoRT
Copy link
Member

@SamMonoRT SamMonoRT commented Aug 20, 2025

Update the gdnbaseline to suppress that warning. Update configure-sdl-tool.ps1 to exclude BinSkim scanning the third party SqlServerSpatial170.dll which doesn't have Control Flow Guard enabled. Not sure why this started showing up recently in the BinSkim runs.

  • I've read the guidelines for contributing and seen the walkthrough
  • I've posted a comment on an issue with a detailed description of how I am planning to contribute and got approval from a member of the team
  • The code builds and tests pass locally (also verified by our automated build checks)
  • Commit messages follow this format:
        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber
  • Tests for the changes have been added (for bug fixes / features)
  • Code follows the same patterns and style as existing code in this repo

Update configure-sdl-tool.ps1 to exclude BinSkim scanning the third party SqlServerSpatial170.dll which doesn't have Control Flow Guard enabled.  Not sure why this started showing up recently in the BinSkim runs.
@SamMonoRT SamMonoRT requested a review from artl93 August 20, 2025 19:09
@SamMonoRT
Copy link
Member Author

cc @artl93 - this is for RC2 and shld resolve a couple work items

@SamMonoRT SamMonoRT merged commit f16aa57 into release/10.0 Aug 20, 2025
7 checks passed
@SamMonoRT SamMonoRT deleted the suppress-ba2008-binskim branch August 20, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants