Skip to content

Suppress BinSkim BA2008 warning for llvm-mca.exe and FileCheck.exe #119376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2025
Merged

Suppress BinSkim BA2008 warning for llvm-mca.exe and FileCheck.exe #119376

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9518c59
Suppress BinSkim BA2008 warning for llvm-mca.exe and FileCheck.exe.
JulieLeeMSFT Sep 4, 2025
5280e74
Add a comment on why external libraries are excluded from binskim sca…
JulieLeeMSFT Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion eng/common/sdl/configure-sdl-tool.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ try {
if ($targetDirectory) {
# Binskim crashes due to specific PDBs. GitHub issue: https://github.com/microsoft/binskim/issues/924.
# We are excluding all `_.pdb` files from the scan.
$tool.Args += "`"Target < $TargetDirectory\**;-:file|$TargetDirectory\**\_.pdb`""
# SuperfileCheck uses two external LLVM libraries (llvm-mca.exe and FileCheck.exe) that we don't build. Excluding them to supporess BA2008.
$tool.Args += "`"Target < $TargetDirectory\**;-:file|$TargetDirectory\**\_.pdb;-:file|$TargetDirectory\**\llvm-mca.exe;-:file|$TargetDirectory\**\FileCheck.exe`""
}
$tool.Args += $BinskimAdditionalRunConfigParams
}
Expand Down
Loading