[release/10.0] Suppress BinSkim BA2008 warning for llvm-mca.exe and FileCheck.exe #119421
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyAyersMS
approved these changes
Sep 6, 2025
jeffschwMSFT
approved these changes
Sep 8, 2025
jeffschwMSFT
added
Servicing-approved
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
|
In the unified build test, binskim still scans the two excluded files. It is because I edited eng/common files, which get overriden by the next arcade update. I will put up a new PR that edits dotnet/eng/pipelines/official.yml. I will close this PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #119376 to release/10.0
/cc @JulieLeeMSFT
Customer Impact
The two external LLVM libraries used by SuperFileCheck are flags as out of compliance. Since we are not building them, we are suppressing the warnings.
Regression
Testing
Waiting for the unified build test is complete. I will update this section once validation is done.
Risk
Low because we are not building those libraries.