Always set BuildingInsideVisualStudio when loading MSBuild workspace #57219
Conversation
ghost
added
the
|
@JoeRobich if we want to fix this for .NET 6 we would need to merge this into 17.0 correct? |
Talked offline. We don't ship MSBuild Workspace as part of the SDK and dotnet-format doesn't need this change because it can set this property on its own. |
|
@jasonmalinowski please take a look. |
| { PropertyNames.DesignTimeBuild, bool.TrueString }, | ||
|
|
||
| // this will force CoreCompile task to execute even if all inputs and outputs are up to date | ||
| #if NETCOREAPP |
There was a problem hiding this comment.
This appears to be an almost direct revert of #40885; does this reintroduce whatever original issue that was fixing?
There was a problem hiding this comment.
@sharwell can you clarify what the original change was for?
There was a problem hiding this comment.
We were hitting dotnet/msbuild#4770, presumably because dotnet/msbuild#5045 wasn't available in one or more SDKs we were executing against.
|
|
||
| // this will force CoreCompile task to execute even if all inputs and outputs are up to date | ||
| #if NETCOREAPP | ||
| { PropertyNames.NonExistentFile, "__NonExistentSubDir__\\__NonExistentFile__" }, |
There was a problem hiding this comment.
The original PR introduced this property name, can we delete it again?
|
Closing this as WPF project loading is fixed. |
It was reported that dotnet-format was failing to load WPF project with the MSBuildWorkspace (See dotnet/format#1337). The necessary change to fix this was to pass
BuildingInsideVisualStudiototruewhich we were already doing for Full Framework. This change makes the behavior the same regardless of which TFM the MSBuild.Workspace library was built for.